Skip to content

Regenerating Python SDK for 2024-12-09 Preview to apply latest breaki… #40649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

amruthashree18
Copy link
Member

…gn change fix on API spec

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@Copilot Copilot AI review requested due to automatic review settings April 22, 2025 18:29
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request regenerates the Python SDK for the 2024-12-09-preview release to apply the latest breaking change fix on the API spec. The updates primarily include refactoring the parameter and attribute naming from "endpoint" to "ledger_endpoint" (and its corresponding URL key "ledgerEndpoint") as well as simplifying the import logic for collections.abc.MutableMapping.

Reviewed Changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated no comments.

File Description
certificate/aio/_operations/_operations.py Removed redundant sys import and simplified MutableMapping import handling.
aio/_configuration.py Renamed constructor parameter and docstring from endpoint to ledger_endpoint.
aio/_client.py Updated internal variable and URL formatting string to use ledgerEndpoint.
Other files Similar renaming updates and consistency improvements applied throughout the SDK files.
Files not reviewed (1)
  • sdk/confidentialledger/azure-confidentialledger/assets.json: Language not supported
Comments suppressed due to low confidence (3)

sdk/confidentialledger/azure-confidentialledger/azure/confidentialledger/certificate/aio/_operations/_operations.py:9

  • The removal of the sys import and version check is appropriate. Please ensure that any related documentation or comments are updated to reflect the simplified import of MutableMapping from collections.abc.
import sys

sdk/confidentialledger/azure-confidentialledger/azure/confidentialledger/aio/_configuration.py:22

  • Ensure that the renaming of the 'endpoint' parameter to 'ledger_endpoint' in both the constructor and its associated documentation is consistent across the SDK.
:param ledger_endpoint: The Confidential Ledger URL, for example

sdk/confidentialledger/azure-confidentialledger/azure/confidentialledger/aio/_client.py:37

  • Confirm that updating the internal variable and URL format string to use 'ledgerEndpoint' is fully aligned with the new API specification and that all corresponding references have been updated.
_endpoint = "{ledgerEndpoint}"

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@amruthashree18 amruthashree18 deleted the amruthashree18/RegenerateSDK-2024-12-09Preview branch April 23, 2025 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants