-
Notifications
You must be signed in to change notification settings - Fork 3k
Make batch deployment subclasses GA #40619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Make batch deployment subclasses GA #40619
Conversation
API change check APIView has identified API level changes in this PR and created following API reviews. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR promotes batch deployment subclasses to general availability by removing experimental markings and updating type hints, parameters, and tests. Key changes include:
- Updating batch deployment and model batch deployment classes to remove experimental wrappers and align with production usage.
- Modifying tests to assert correct type properties and improve settings attribute access.
- Refactoring import orders and parameter types to match current SDK requirements.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
sdk/ml/azure-ai-ml/tests/test_configs/deployments/batch/pipeline_component_batch_deployment.yml | Removed the explicit "-type: pipeline" entry to rely on default type settings. |
sdk/ml/azure-ai-ml/tests/batch_online_common/unittests/test_pipeline_component_bach_deployment.py | Added assertions for the type property; consider checking for naming consistency. |
sdk/ml/azure-ai-ml/tests/batch_online_common/unittests/test_model_batch_deployment.py | Added tests for the getter/setter of ModelBatchDeployment settings. |
sdk/ml/azure-ai-ml/tests/batch_online_common/unittests/test_deployment_entity.py | Introduced tests for deployment attribute access and warning of deprecated batch deployment usage. |
sdk/ml/azure-ai-ml/azure/ai/ml/entities/_deployment/pipeline_component_batch_deployment.py | Updated the inheritance and type handling to remove dual type parameters when initializing. |
sdk/ml/azure-ai-ml/azure/ai/ml/entities/_deployment/model_batch_deployment_settings.py | Adjusted output_action type to allow string values alongside the enum. |
sdk/ml/azure-ai-ml/azure/ai/ml/entities/_deployment/model_batch_deployment.py | Changed parameter types and ensured consistency with the new deployment structure. |
sdk/ml/azure-ai-ml/azure/ai/ml/entities/_deployment/batch_deployment.py | Introduced a warning for direct usage of the base class and refactored settings initialization. |
sdk/ml/azure-ai-ml/azure/ai/ml/_schema/_deployment/batch/pipeline_component_batch_deployment_schema.py | Updated type field definition to use the new StringTransformedEnum for allowed values. |
Comments suppressed due to low confidence (2)
sdk/ml/azure-ai-ml/tests/batch_online_common/unittests/test_pipeline_component_bach_deployment.py:1
- The filename 'test_pipeline_component_bach_deployment.py' appears to have a typo ('bach' instead of 'batch'). Consider renaming it for improved clarity.
Filename: test_pipeline_component_bach_deployment.py
sdk/ml/azure-ai-ml/azure/ai/ml/entities/_deployment/pipeline_component_batch_deployment.py:63
- [nitpick] Consider renaming the local variable '_type' to a more descriptive name (for example, 'deployment_type') to avoid confusion with the built-in 'type' function and enhance code clarity.
_type = kwargs.pop("type", type)
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines