-
Notifications
You must be signed in to change notification settings - Fork 3k
[Storage] Fixed Download/Upload APIs to be compatible with all transports + responses #40615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Storage] Fixed Download/Upload APIs to be compatible with all transports + responses #40615
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Download/Upload APIs to ensure compatibility across all transport types and responses. Key changes include:
- Updating exception handling in multiple asynchronous policies modules to include AttributeError.
- Adjustments in test modules and helpers to better distinguish between legacy and modern transport responses.
- Modifications to asynchronous blob download logic to handle partially consumed streams.
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
sdk/storage/azure-storage-queue/azure/storage/queue/_shared/policies_async.py | Updated exception handling to catch AttributeError when loading response body. |
sdk/storage/azure-storage-file-share/azure/storage/fileshare/_shared/policies_async.py | Similar update to exception handling for broader transport compatibility. |
sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_shared/policies_async.py | Exception handling modified to include AttributeError for improved compatibility. |
sdk/storage/azure-storage-blob/azure/storage/blob/aio/_download_async.py | Modified content processing to check if the response stream is already consumed. |
sdk/storage/azure-storage-blob/azure/storage/blob/_shared/policies_async.py | Exception handling updated to include AttributeError. |
(Test files) | Adjustments made in transport tests and helper modules to align with new transport responses. |
Files not reviewed (1)
- sdk/storage/azure-storage-blob/assets.json: Language not supported
sdk/storage/azure-storage-queue/azure/storage/queue/_shared/policies_async.py
Show resolved
Hide resolved
sdk/storage/azure-storage-file-share/azure/storage/fileshare/_shared/policies_async.py
Show resolved
Hide resolved
sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_shared/policies_async.py
Show resolved
Hide resolved
sdk/storage/azure-storage-blob/azure/storage/blob/_shared/policies_async.py
Show resolved
Hide resolved
API change check API changes are not detected in this pull request. |
Odd reason for test failures - in the
|
No description provided.