A suggestion for #40518 - don't serialize args and simplify code #40597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmolkova
requested review from
luigiw,
needuv,
paulshealy1,
singankit,
dargilco and
jhakulin
as code owners
lmolkova
commented
Apr 18, 2025
| @@ -306,17 +304,17 @@ def _create_event_attributes( | |||
|
|
|||
| if cancelled_at: | |||
| if isinstance(cancelled_at, datetime): | |||
| attrs[GEN_AI_RUNSTEP_CANCEL_TIMESTAMP] = cancelled_at.isoformat() | |||
There was a problem hiding this comment.
we record status of step on line 289, no need to make it part of the attribute name
lmolkova
commented
Apr 18, 2025
| @@ -408,41 +380,24 @@ def _process_tool_calls(self, step: RunStep) -> List[Dict[str, Any]]: | |||
| }, | |||
| } | |||
| elif isinstance(t, RunStepCodeInterpreterToolCall): | |||
| try: | |||
| parsed_outputs = json.dumps(t.code_interpreter.outputs) | |||
There was a problem hiding this comment.
this results in a huge escaped string, there is no need to dump it.
lmolkova
commented
Apr 18, 2025
| }, | ||
| } | ||
| elif isinstance(t, RunStepBingGroundingToolCall): | ||
| bing_grounding = {} | ||
| try: | ||
| bing_grounding = json.dumps(t.bing_grounding) |
There was a problem hiding this comment.
same here, dumping results in a string rather than object
lmolkova
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.