Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Coverage Improvemt - remove rest client from test coverage #38943

Merged
merged 14 commits into from
Dec 30, 2024
Merged

Test Coverage Improvemt - remove rest client from test coverage #38943

merged 14 commits into from
Dec 30, 2024

Conversation

pdhotems
Copy link
Member

@pdhotems pdhotems commented Dec 19, 2024 •
edited
Loading

Description

Remove restClient from considering test coverage

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@pdhotems pdhotems enabled auto-merge (squash) December 30, 2024 06:39
@pdhotems pdhotems merged commit 1820bd0 into main Dec 30, 2024
21 checks passed
@pdhotems pdhotems deleted the pdhote/tc-rest-client-remove branch December 30, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kingernupur kingernupur kingernupur approved these changes

@jayesh-tanna jayesh-tanna jayesh-tanna approved these changes

@paulshealy1 paulshealy1 Awaiting requested review from paulshealy1 paulshealy1 is a code owner

@achauhan-scc achauhan-scc Awaiting requested review from achauhan-scc achauhan-scc is a code owner

Assignees
No one assigned
Labels
Machine Learning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pdhotems @azure-sdk @jayesh-tanna @kingernupur