ExposeFeedRangeAsClassType #37444
Merged
ExposeFeedRangeAsClassType #37444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run python - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
annatisch
reviewed
Sep 22, 2024
sdk/cosmos/azure-cosmos/azure/cosmos/_change_feed/change_feed_state.py
Outdated
Show resolved
Hide resolved
| @@ -79,7 +80,7 @@ def apply_server_response_continuation(self, continuation: str, has_modified_res | |||
| def from_json( | |||
| container_link: str, | |||
| container_rid: str, | |||
| change_feed_state_context: Dict[str, Any]): | |||
| change_feed_state_context: Dict[str, Any]) -> 'ChangeFeedState': | |||
There was a problem hiding this comment.
Looks like it should be a function, not a staticmethod.
sdk/cosmos/azure-cosmos/azure/cosmos/_execution_context/aio/base_execution_context.py
Show resolved
Hide resolved
| } | ||
|
|
||
| def _to_feed_range_internal(self) -> 'FeedRangeInternal': | ||
| return FeedRangeInternalEpk(self._feed_range) |
There was a problem hiding this comment.
The method feels a bit redundant - why can't the constructor of FeedRangeInternalEpk just accept an instance of FeedRangeEpk?
xinlian12
requested review from
mccoyp,
catalinaperalta,
kristapratico,
iscai-msft,
lmazuel,
scbedd,
a team,
weshaggard,
benbp,
ChenxiJiang333,
msyyc,
kashifkhan and
swathipil
as code owners
xinlian12
requested review from
gfeitosa-msft,
besh2014,
phermanov-msft,
ilyapaliakou-msft,
yogeshmo,
jingjlii,
JJJessieWang,
wanghoppe,
dpwatrous,
wiboris,
cRui861,
jalauzon-msft,
vincenttran-msft,
weirongw23-msft,
pvaneck,
a team,
luigiw,
needuv,
singankit and
johanste
as code owners
xinlian12
requested review from
maorleger,
christothes,
ahsonkhan,
schaabs and
mpodwysocki
added 2 commits
September 23, 2024 12:16
…seFeedRangeAsClassType
xinlian12
merged commit b75c260
into
Azure:users/xinlian/feature/feedRangeAndChangeFeed
3 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second PR for exposingFeedRange in change feed query. In PR #36930, we have exposed feedRange as a
strtype, but it comes with perf penalty - for eachread_feed_rangesresponse, we would have to always do the base64 encoding, and for eachquery_items_change_feedusingfeed_rangewe have to decode the string.In this PR, we will expose a FeedRange class type