Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(playwrighttesting): use playwright OSS types #32319

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Sid200026
Copy link
Member

Packages impacted by this PR

@azure/microsoft-playwright-testing

Issues associated with this PR

Type changes by playwright OSS will impact @azure/microsoft-playwright-testing SDK if relevant types are hardcoded.

Describe the problem that is addressed by this PR

Instead of having playwright OSS types hardcoded in the package, we will use the types provided by the playwright OSS package itself (Playwright OSS is added as a peer dependency).

This also changes peer dependency version of playwright OSS to v1.47, which is the minimum supported version of playwright OSS for this SDK.

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

Provide a list of related PRs (if any)

Command used to generate this PR:**(Applicable only to SDK release request PRs)

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

@azure/microsoft-playwright-testing

@Sid200026
Copy link
Member Author

Also renamed MPTReporterConfiguration to ReporterConfiguration as per APIView review

@Sid200026
Copy link
Member Author

This PR also removes the below constants from the public variable ServiceEnvironmentVariable

    PLAYWRIGHT_SERVICE_OS
    PLAYWRIGHT_SERVICE_EXPOSE_NETWORK_ENVIRONMENT_VARIABLE
    PLAYWRIGHT_SERVICE_REPORTING_URL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants