-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(playwrighttesting): use playwright OSS types #32319
Open
Sid200026
wants to merge
8
commits into
Azure:main
Choose a base branch
from
Sid200026:users/ssingharoy/use-playwright-oss-types
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
chore(playwrighttesting): use playwright OSS types #32319
Sid200026
wants to merge
8
commits into
Azure:main
from
Sid200026:users/ssingharoy/use-playwright-oss-types
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sid200026
requested review from
bterlson,
a team,
puagarwa and
ShreyaAnand
as code owners
December 20, 2024 06:17
API change check APIView has identified API level changes in this PR and created following API reviews. |
…per APIView review
Also renamed |
mxschmitt
approved these changes
Dec 20, 2024
sdk/playwrighttesting/microsoft-playwright-testing/test/utils/clInfoProvider.spec.ts
Outdated
Show resolved
Hide resolved
…clInfoProvider.spec.ts Co-authored-by: Max Schmitt <[email protected]>
This reverts commit f42202f.
This reverts commit 8ab8306.
This PR also removes the below constants from the public variable
|
kashish2508
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/microsoft-playwright-testing
Issues associated with this PR
Type changes by playwright OSS will impact @azure/microsoft-playwright-testing SDK if relevant types are hardcoded.
Describe the problem that is addressed by this PR
Instead of having playwright OSS types hardcoded in the package, we will use the types provided by the playwright OSS package itself (Playwright OSS is added as a peer dependency).
This also changes peer dependency version of playwright OSS to v1.47, which is the minimum supported version of playwright OSS for this SDK.
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists