Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Tracing for Agents #32020

Merged
merged 13 commits into from
Dec 9, 2024
Merged

Adding Tracing for Agents #32020

merged 13 commits into from
Dec 9, 2024

Conversation

ganeshyb
Copy link
Member

@ganeshyb ganeshyb commented Dec 2, 2024 •
edited
Loading

Adding Tracing for Agents
Introduce Tracing Utility that provides utility functions for adding span attributes and wrap span with start and end functions that can be called.
TODO : Streaming Events.

@ganeshyb ganeshyb changed the title Users/ganeshbh/agents tracing Adding Tracing for Agents Dec 2, 2024
maorleger
maorleger reviewed Dec 2, 2024
View reviewed changes
Copy link
Member

@maorleger maorleger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments but most are non-blocking. I would like to get a clear answer on the connectionString usage in telemetry though. Happy to chat about any of these comments if you'd like!

sdk/ai/ai-projects/samples-dev/agents/agents_basics_tracing_console.ts Outdated Show resolved Hide resolved
sdk/ai/ai-projects/samples-dev/agents/agents_basics_tracing_console.ts Outdated Show resolved Hide resolved
sdk/ai/ai-projects/samples-dev/agents/agents_basics_tracing_console.ts Outdated Show resolved Hide resolved
sdk/ai/ai-projects/src/agents/assistants.ts Outdated Show resolved Hide resolved
sdk/ai/ai-projects/src/agents/assistantsTrace.ts Outdated Show resolved Hide resolved
sdk/ai/ai-projects/src/agents/traceUtility.ts Show resolved Hide resolved
sdk/ai/ai-projects/src/agents/traceUtility.ts Outdated Show resolved Hide resolved
sdk/ai/ai-projects/src/telemetry/telemetry.ts Outdated Show resolved Hide resolved
maorleger
maorleger approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@maorleger maorleger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more comments for your consideration but otherwise makes sense.

sdk/ai/ai-projects/src/agents/assistants.ts Outdated Show resolved Hide resolved
sdk/ai/ai-projects/src/agents/assistants.ts Show resolved Hide resolved
sdk/ai/ai-projects/src/agents/assistantsTrace.ts Outdated Show resolved Hide resolved
sdk/ai/ai-projects/src/tracing.ts Outdated Show resolved Hide resolved
sdk/ai/ai-projects/src/tracing.ts Outdated Show resolved Hide resolved
sdk/ai/ai-projects/src/tracing.ts Outdated Show resolved Hide resolved
sdk/ai/ai-projects/src/tracing.ts Outdated Show resolved Hide resolved
sdk/ai/ai-projects/src/tracing.ts Outdated Show resolved Hide resolved
@ganeshyb ganeshyb merged commit e9034fa into feature/azure-ai-sdk Dec 9, 2024
3 of 4 checks passed
@ganeshyb ganeshyb deleted the users/ganeshbh/agents-tracing branch December 9, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maorleger maorleger maorleger approved these changes

@xirzec xirzec xirzec left review comments

@ckairen ckairen Awaiting requested review from ckairen ckairen is a code owner

@jeremymeng jeremymeng Awaiting requested review from jeremymeng jeremymeng is a code owner

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ganeshyb @xirzec @maorleger