Adding upload file and poll operation with sample and test #31928
Conversation
ZachhK
changed the title
| await new Promise(resolve => setTimeout(resolve, sleepInterval)); | ||
| const updatedResult = await context.path(`/files/${result.body.id}`, result.body.id).get(options); | ||
| result.body = updatedResult.body; | ||
| } |
There was a problem hiding this comment.
Provide a way to stop polling.
| @@ -31,6 +31,19 @@ export async function uploadFile( | |||
| return result.body; | |||
| } | |||
|
|
|||
| /** Uploads a file for use by other operations. */ | |||
| export async function uploadFileAndPoll( | |||
There was a problem hiding this comment.
@ganeshyb would we want to use an LRO here?
There was a problem hiding this comment.
I am not sure actually, could you help me understand what the traffic will look like?
We leverage the first request to upload the file successfully but when this request is back this doesn't mean the server side is completed. So we have following requests to poll status? Will this be the traffic?
There was a problem hiding this comment.
Yes, The scenarios is first the user uploads the file, based on the file size and processing on the backend, its goes through states like pending, running, This api waits for the file to be uploaded and wait till its processed.
There was a problem hiding this comment.
Interesting, this seems to be an LRO operation for me and it would be a case like multipart/form-data + LRO. I have two questions here:
- Does this operation follow our LRO guideline?
- Have we reviewed with this with our architects? Why the spec is a still normal operation?
…e-sdk-for-js into zacharyking/updateFilePoll
…e-sdk-for-js into zacharyking/updateFilePoll
…e-sdk-for-js into zacharyking/updateFilePoll
…K/azure-sdk-for-js into zacharyking/updateFilePoll
| @@ -7,7 +7,7 @@ import { AbortSignalLike } from "@azure/abort-controller"; | |||
| import { PollingOptions } from "./customModels.js"; | |||
|
|
|||
| interface PollResult { | |||
| status: string; | |||
| status?: string; | |||
| } else { | ||
| file = await getFile(context, currentResult.id, options); | ||
| } | ||
| return { result: file, completed: file.status !== "pending" && file.status !== "running" }; |
There was a problem hiding this comment.
Could we check terminal states ?
There was a problem hiding this comment.
Changed to check terminal states
| @@ -31,6 +31,19 @@ export async function uploadFile( | |||
| return result.body; | |||
| } | |||
|
|
|||
| /** Uploads a file for use by other operations. */ | |||
| export async function uploadFileAndPoll( | |||
There was a problem hiding this comment.
Yes, The scenarios is first the user uploads the file, based on the file size and processing on the backend, its goes through states like pending, running, This api waits for the file to be uploaded and wait till its processed.
No description provided.