Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[identity] Various test fixes #31764

Merged
merged 3 commits into from
Nov 14, 2024
Merged

[identity] Various test fixes #31764

merged 3 commits into from
Nov 14, 2024

Conversation

maorleger
Copy link
Member

@maorleger maorleger commented Nov 14, 2024 •
edited
Loading

A few fixes as a result of the identity ESM migration:

  1. Missing ctx parameter that's now fixed
  2. Default vitest config excludes managed identity tests. Adding a separate vitest config for managed identity test runs fixes this

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@maorleger maorleger marked this pull request as ready for review November 14, 2024 17:51
@maorleger maorleger enabled auto-merge (squash) November 14, 2024 21:39
@maorleger maorleger merged commit a6b5a36 into Azure:main Nov 14, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpodwysocki mpodwysocki mpodwysocki approved these changes

@KarishmaGhiya KarishmaGhiya Awaiting requested review from KarishmaGhiya KarishmaGhiya is a code owner

@minhanh-phan minhanh-phan Awaiting requested review from minhanh-phan minhanh-phan is a code owner

@schaabs schaabs Awaiting requested review from schaabs schaabs is a code owner

@christothes christothes Awaiting requested review from christothes christothes is a code owner automatically assigned from Azure/azure-sdk-write-identity

@pvaneck pvaneck Awaiting requested review from pvaneck pvaneck is a code owner automatically assigned from Azure/azure-sdk-write-identity

@g2vinay g2vinay Awaiting requested review from g2vinay g2vinay is a code owner automatically assigned from Azure/azure-sdk-write-identity

Assignees
No one assigned
Labels
Azure.Identity
Projects
Azure Identity SDK Improvements
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maorleger @azure-sdk @mpodwysocki