Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Identity] Fix the resource deployment step for MI tests #31751

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

KarishmaGhiya
Copy link
Member

@KarishmaGhiya KarishmaGhiya commented Nov 13, 2024

  • The resource deployment script for MI tests has been failing. Fixing this by:
  1. Setting the location explicitly to westus2
    Reason:
    We need to deploy vms in the TME tenant, the default region of westus doesnt work. Have to set the Location to westus2, as it has quota for vms/aks. Otherwise we get the error like this :
Preflight validation check for resource(s) for container service t32358a8eb2bf4865 in resource group rg-identity-t32358a8eb2bf4865 failed. Message: The VM size of Standard_D2s_v3 is not allowed in your subscription in location 'westus'.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@KarishmaGhiya KarishmaGhiya changed the title don't pin azure cli to specific version [Identity] Fix the resource deployment for MI tests Nov 14, 2024
@KarishmaGhiya KarishmaGhiya marked this pull request as ready for review November 21, 2024 01:25
@KarishmaGhiya KarishmaGhiya changed the title [Identity] Fix the resource deployment for MI tests [Identity] Fix the resource deployment step for MI tests Nov 21, 2024
Copy link
Member

@pvaneck pvaneck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @KarishmaGhiya, noticing that there is some overlap with #31335. Perhaps, we should press to get that one merged and have the azure-cli change be separate?

Copy link
Member

@maorleger maorleger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@KarishmaGhiya
Copy link
Member Author

Hey @KarishmaGhiya, noticing that there is some overlap with #31335. Perhaps, we should press to get that one merged and have the azure-cli change be separate?

Thanks for this! I chatted with Ben, he's ok with me merging this for now.

@KarishmaGhiya KarishmaGhiya merged commit e99dc0b into Azure:main Nov 21, 2024
40 checks passed
@KarishmaGhiya KarishmaGhiya deleted the test-resources branch November 21, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

5 participants