[Identity] update recordings for msal-common and msal-node updates #31735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API change check API changes are not detected in this pull request. |
KarishmaGhiya
force-pushed
the
update-msa
branch
2 times, most recently
from
bd258c2 to
2ecc2f3
Compare
KarishmaGhiya
changed the title
KarishmaGhiya
requested review from
minhanh-phan,
maorleger,
schaabs and
a team
as code owners
KarishmaGhiya
requested review from
pvaneck,
ahsonkhan,
chlowell and
mpodwysocki
jeremymeng
approved these changes
Nov 21, 2024
KarishmaGhiya
force-pushed
the
update-msa
branch
from
74efe5e to
c3423e2
Compare
Seems like my git push had got messed up @jeremymeng Hopefully it's fixed now. Feel free to review again. |
KarishmaGhiya
requested review from
mikeharder and
deyaaeldeen
as code owners
|
/azp run js - core - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
KarishmaGhiya
force-pushed
the
update-msa
branch
from
3f5e811 to
445c918
Compare
KarishmaGhiya
force-pushed
the
update-msa
branch
from
816a304 to
ad1f2e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the recent upgrades to msal node (2.15 to 2.16) and msal common (14.15 to 14.16), the request uri used by msal has now been updated to include the client-request-id as a query parameter in the request uri. I have manually updated recordings of the tests to reflect the change, in order to fix the breaking recorded tests after upgrading dependecy on msal.
Unable to re-record the tests to auto-generate the recordings, due to tenant restrictions, hence manually updated the recordings.
Also unpinning the msal dependency that were pinned in this PR - #31819