Fix compiler errors in tests and samples #31649
Merged
+200
−85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `dev-tool run typecheck` will report compiler diagnostics without emitting output.
jeremymeng
requested review from
mikeharder,
ckairen,
deyaaeldeen,
mpodwysocki,
timovv,
hectorhdzg,
JacksonWeber,
harsimar,
maorleger,
wiboris,
wanghoppe,
dpwatrous,
cRui861,
skapur12,
a team and
joheredi
as code owners
jeremymeng
commented
Nov 5, 2024
jeremymeng
commented
Nov 5, 2024
jeremymeng
commented
Nov 5, 2024
jeremymeng
commented
Nov 5, 2024
jeremymeng
commented
Nov 5, 2024
jeremymeng
commented
Nov 5, 2024
|
API change check API changes are not detected in this pull request. |
mpodwysocki
approved these changes
Nov 6, 2024
hectorhdzg
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After moving to ESM/tshy, we no longer build tests/samples. This PR enables running "typecheck" as an optional rush bulk command, and fixes some of the errors found.
The known errors reported on files from vite/vitest/chai are ignored.
The update-snippets dev-tool command throws error of reading undefined in some cases, adding a null check fixes it.
Snippets are updated as well after snippets.spec.ts files are fixed.