Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[identity] Migrate to ESM and tshy #31647

Merged
merged 6 commits into from
Nov 13, 2024
Merged

[identity] Migrate to ESM and tshy #31647

merged 6 commits into from
Nov 13, 2024

Conversation

maorleger
Copy link
Member

@maorleger maorleger commented Nov 5, 2024 •
edited
Loading

Packages impacted by this PR

@azure/identity-broker
@azure/identity

Issues associated with this PR

#31338

Describe the problem that is addressed by this PR

Migrates identity and identity-broker to ESM, tshy, and Vitest

Checklists

  • Added impacted package name to the issue description.
  • Does this PR need any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here.)
  • Added a changelog (if necessary).

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@maorleger maorleger force-pushed the identity-esm branch 2 times, most recently from 003733f to b27119c Compare November 7, 2024 22:57
@maorleger maorleger marked this pull request as ready for review November 7, 2024 22:58
xirzec
xirzec approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@xirzec xirzec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor remarks, but looks good to me! Thanks for tackling this

common/tools/dev-tool/src/commands/admin/migrate-package.ts Show resolved Hide resolved
sdk/identity/identity/package.json Show resolved Hide resolved
sdk/identity/identity/src/package.json Outdated Show resolved Hide resolved
sdk/identity/identity/test/integration/azureFunctionsTest.spec.ts Outdated Show resolved Hide resolved
sdk/identity/identity/test/internal/node/azureCliCredential.spec.ts Show resolved Hide resolved
sdk/identity/identity/test/internal/node/identityClient.spec.ts Show resolved Hide resolved
@maorleger maorleger merged commit 86ed16f into Azure:main Nov 13, 2024
34 checks passed
@maorleger maorleger deleted the identity-esm branch November 13, 2024 23:26
@maorleger maorleger mentioned this pull request Dec 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xirzec xirzec xirzec approved these changes

@KarishmaGhiya KarishmaGhiya KarishmaGhiya approved these changes

@mpodwysocki mpodwysocki mpodwysocki approved these changes

@jeremymeng jeremymeng Awaiting requested review from jeremymeng jeremymeng is a code owner

@timovv timovv Awaiting requested review from timovv timovv is a code owner

@ckairen ckairen Awaiting requested review from ckairen ckairen is a code owner

@minhanh-phan minhanh-phan Awaiting requested review from minhanh-phan minhanh-phan is a code owner

@schaabs schaabs Awaiting requested review from schaabs schaabs is a code owner

@pvaneck pvaneck Awaiting requested review from pvaneck pvaneck is a code owner automatically assigned from Azure/azure-sdk-write-identity

@g2vinay g2vinay Awaiting requested review from g2vinay g2vinay is a code owner automatically assigned from Azure/azure-sdk-write-identity

@ahsonkhan ahsonkhan Awaiting requested review from ahsonkhan ahsonkhan is a code owner automatically assigned from Azure/azure-sdk-write-identity

Assignees
No one assigned
Labels
Azure.Identity
Projects
Azure Identity SDK Improvements
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@maorleger @azure-sdk @xirzec @KarishmaGhiya @mpodwysocki