Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix client type issues and improve tests #31617

Merged
merged 9 commits into from
Nov 20, 2024
Merged

Fix client type issues and improve tests #31617

merged 9 commits into from
Nov 20, 2024

Conversation

cqnguy23
Copy link
Member

@cqnguy23 cqnguy23 commented Nov 2, 2024 •
edited
Loading

  • Add a test util to parse JWT token payload to validate audience
  • Add more tests for AAD
  • Fix mismatched DTO field when calling generateClientToken

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@cqnguy23 cqnguy23 marked this pull request as ready for review November 4, 2024 06:22
@cqnguy23 cqnguy23 merged commit 4dafd34 into Azure:main Nov 20, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vicancy vicancy vicancy approved these changes

@chenkennt chenkennt Awaiting requested review from chenkennt chenkennt is a code owner

@zackliu zackliu Awaiting requested review from zackliu zackliu is a code owner

Assignees
No one assigned
Labels
WebPubSub
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cqnguy23 @azure-sdk @vicancy