[core-amqp] set the max listener limit to 1000 for sender and receiver #20088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NodeJS would issue warning if the number of disconnected listeners on an event emitter exceeds 10. When many sessions on a connection are closed but the removal of the listener hasn't caught up, we will see this warning because the default limit of 10 in NodeJS is too low. The disconnected listeners DO get removed eventually in our code. We already do this for senders created in Service Bus. This PR increase the limit to 1000 for senders and receivers created off `ConnectionContextBase.connection` so that the limites apply to both Service Bus and Event Hubs.
ghost
added
the
|
test failure due to known sanitizer issue. |
deyaaeldeen
reviewed
Feb 1, 2022
| */ | ||
| async createSender(options?: CreateSenderOptions): Promise<Sender> { | ||
| const sender = await super.createSender(options); | ||
| sender.setMaxListeners(1000); |
There was a problem hiding this comment.
should this 1000 be put in a variable instead so it is easier to update it everywhere if there is a need to?
deyaaeldeen
approved these changes
Feb 1, 2022
ramya-rao-a
approved these changes
Feb 1, 2022
Should we also update Service Bus to remove the setting of this limit in this PR now that this comes from core-amqp? |
Yes! I was going to do that once you all are fine with this approach. |
This was referenced Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NodeJS would issue warning if the number of disconnected listeners on an event
emitter exceeds 10. When many sessions on a connection are closed but the
removal of the listener hasn't caught up, we will see this warning because the
default limit of 10 in NodeJS is too low. The disconnected listeners DO get
removed eventually in our code.
We already do this for senders created in Service Bus. This PR increase the
limit to 1000 for senders and receivers created off
ConnectionContextBase.connectionso that the limites apply to both Service Busand Event Hubs.
Packages impacted by this PR
core-amqp, service-bus, event-hub
Issues associated with this PR
#12161
Describe the problem that is addressed by this PR
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
MaxListenersExceededWarning- "disconnected listeners" withdisconnectEventAudienceMapamqp/rhea-promise#78 complicatedAre there test cases added in this PR? (If not, why?)
no functionality changes. covered by stress tests