[EngSys] Pin @azure/msal-* version temporarily #31819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremymeng
requested review from
ckairen,
a team,
mikeharder and
deyaaeldeen
as code owners
xirzec
approved these changes
Nov 18, 2024
jeremymeng
requested review from
mpodwysocki,
timovv,
KarishmaGhiya,
minhanh-phan,
maorleger,
schaabs and
a team
as code owners
mpodwysocki
approved these changes
Nov 18, 2024
|
API change check API changes are not detected in this pull request. |
because upgrading them caused identity unit tests to fail. This allows us to upgrade other packages to address security alerts.
to get fix to this issue typescript-eslint/typescript-eslint#10338
jeremymeng
force-pushed
the
engsys/pin-msal-versions
branch
from
ba3c9dc to
756969d
Compare
This reverts commit 5693ba6.
>/home/meng/git/jssdk/sdk/monitor/monitor-opentelemetry-exporter/src/utils/logUtils.ts
63:26 error 'exceptionType' may use Object's default stringification format ('[object Object]') when stringified @typescript-eslint/no-base-to-string
86:23 error 'log.attributes[ApplicationInsightsBaseType]' may use Object's default stringification format ('[object Object]') when stringified @typescript-eslint/no-base-to-string
101:32 error 'properties[key]' may use Object's default stringification format ('[object Object]') when stringified @typescript-eslint/no-base-to-string
KarishmaGhiya
added a commit
that referenced
this pull request
Nov 27, 2024
…31735) With the recent upgrades to msal node (2.15 to 2.16) and msal common (14.15 to 14.16), the request uri used by msal has now been updated to include the client-request-id as a query parameter in the request uri. I have manually updated recordings of the tests to reflect the change, in order to fix the breaking recorded tests after upgrading dependecy on msal. Unable to re-record the tests to auto-generate the recordings, due to tenant restrictions, hence manually updated the recordings. Also unpinning the msal dependency that were pinned in this PR - #31819
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because upgrading them caused identity unit tests to fail. This allows us to upgrade other packages to address security alerts.