Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live tests are failing with chai 4.4.0 #28185

Closed
jeremymeng opened this issue Jan 8, 2024 · 1 comment
Closed

Live tests are failing with chai 4.4.0 #28185

jeremymeng opened this issue Jan 8, 2024 · 1 comment
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. test-reliability Issue that causes tests to be unreliable

Comments

@jeremymeng
Copy link
Member

after recent rush full update, running tests on .js input files is broken because of the ?? syntax in chai 4.4.0, which isn't supported by esm package.

@jeremymeng jeremymeng added Client This issue points to a problem in the data-plane of the library. test-reliability Issue that causes tests to be unreliable labels Jan 8, 2024
@jeremymeng jeremymeng self-assigned this Jan 8, 2024
jeremymeng added a commit to jeremymeng/azure-sdk-for-js that referenced this issue Jan 8, 2024
Recent upgrade of `chai` from `4.3.10` to `4.4` broke our integration tests
which use `esm` to transform *.js test files.  The new version contains `??`
syntax that is not supported by `esm`.

This PR pins `chai` version to `4.3.10`. Issue Azure#28185 is created to track
follow-up work.
jeremymeng added a commit that referenced this issue Jan 9, 2024
Recent upgrade of `chai` from `4.3.10` to `4.4` broke our integration
tests which use `esm` to transform *.js test files. The new version
contains `??` syntax that is not supported by `esm`.

This PR pins `chai` version to `4.3.10`. Issue #28185 is created to
track follow-up work.
jeremymeng added a commit to jeremymeng/azure-sdk-for-js that referenced this issue Dec 4, 2024
This resolves issue Azure#28185.  I had to add "chai" dev dependency back to two
packages because "chai-as-promised" needs it as peer dependency
@jeremymeng
Copy link
Member Author

we removed esm dependency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. test-reliability Issue that causes tests to be unreliable
Projects
None yet
Development

No branches or pull requests

1 participant