[engsys] pin dev dependency chai version to 4.3.10
#28186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent upgrade of `chai` from `4.3.10` to `4.4` broke our integration tests which use `esm` to transform *.js test files. The new version contains `??` syntax that is not supported by `esm`. This PR pins `chai` version to `4.3.10`. Issue Azure#28185 is created to track follow-up work.
jeremymeng
requested review from
mikeharder,
ckairen and
deyaaeldeen
as code owners
|
/azp run js - data-tables - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - data-tables - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
deyaaeldeen
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent upgrade of
chaifrom4.3.10to4.4broke our integration tests which useesmto transform *.js test files. The new version contains??syntax that is not supported byesm.This PR pins
chaiversion to4.3.10. Issue #28185 is created to track follow-up work.