Skip to content

Commit

Permalink
[keyvault-secrets] Migrate to TypeSpec (#31848)
Browse files Browse the repository at this point in the history
### Packages impacted by this PR

@azure/keyvault-secrets

### Issues associated with this PR

#31512

### Describe the problem that is addressed by this PR

Migrates keyvault-secrets to TypeSpec
  • Loading branch information
maorleger authored Jan 21, 2025
1 parent 40e561f commit e336721
Show file tree
Hide file tree
Showing 32 changed files with 1,769 additions and 1,997 deletions.
42 changes: 42 additions & 0 deletions sdk/keyvault/generate.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
#!/usr/bin/env node

const { execSync } = require("child_process");
const fs = require("fs");
const path = require("path");

// Helper to execute shell commands and log output
function execCommand(command) {
try {
execSync(command, { stdio: "inherit" });
} catch (error) {
console.error(`Command failed: ${command}`);
process.exit(1);
}
}

console.log("Setting up the environment...");

// Workaround for src-folder support in emitter:
// End state: src/generated/* contains generated code (instead of src/generated/src/*)

// Step 1: Remove all files in src/generated/*
execCommand("rm -rf src/generated/*");

// Step 2: Copy tsp-location.yaml to src/generated
execCommand("cp tsp-location.yaml src/generated");

// Step 3: Run tsp-client command
// emitter-option as a workaround for https://github.com/Azure/azure-rest-api-specs/issues/31610
execCommand(`tsp-client update -d -o src/generated --emitter-options generateMetadata=false`);
// execCommand(
// "tsp-client update -d -o src/generated --tsp-config ~/workspace/azure-rest-api-specs/specification/keyvault/Security.KeyVault.Keys/tspconfig.yaml --local-spec-repo ~/workspace/azure-rest-api-specs/specification/keyvault/Security.KeyVault.Keys --repo ~/workspace/azure-rest-api-specs --commit 9561bad7d2eed94cc91aa6164d3721b8aa8699fe --emitter-options generateMetadata=false"
// );

// Step 4: Move generated/src/* files to generated until src-folder is supported
execCommand("mv src/generated/src/* src/generated/");

// Step 5: Remove generated/src
execCommand("rm -rf src/generated/src");

// Step 6: Remove tsp-location.yaml from generated folder
execCommand("rm src/generated/tsp-location.yaml");
2 changes: 2 additions & 0 deletions sdk/keyvault/keyvault-secrets/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@

### Other Changes

- Generate code from TypeSpec. This is an internal change that should not affect customers. [#31848](https://github.com/Azure/azure-sdk-for-js/pull/31848)

## 4.9.0 (2024-10-16)

### Features Added
Expand Down
2 changes: 1 addition & 1 deletion sdk/keyvault/keyvault-secrets/assets.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
"AssetsRepo": "Azure/azure-sdk-assets",
"AssetsRepoPrefixPath": "js",
"TagPrefix": "js/keyvault/keyvault-secrets",
"Tag": "js/keyvault/keyvault-secrets_41e131fba8"
"Tag": "js/keyvault/keyvault-secrets_2d29630751"
}
4 changes: 2 additions & 2 deletions sdk/keyvault/keyvault-secrets/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
"test:node": "npm run clean && npm run build:test && npm run unit-test:node",
"unit-test": "npm run unit-test:node && npm run unit-test:browser",
"unit-test:browser": "echo skipped",
"unit-test:node": "dev-tool run test:vitest",
"unit-test:node": "dev-tool run test:vitest -- --test-timeout 250000",
"update-snippets": "echo skipped"
},
"sideEffects": false,
Expand Down Expand Up @@ -92,9 +92,9 @@
}
},
"dependencies": {
"@azure-rest/core-client": "^2.3.2",
"@azure/abort-controller": "^2.0.0",
"@azure/core-auth": "^1.3.0",
"@azure/core-client": "^1.5.0",
"@azure/core-http-compat": "^2.0.1",
"@azure/core-lro": "^2.2.0",
"@azure/core-paging": "^1.1.1",
Expand Down
4 changes: 2 additions & 2 deletions sdk/keyvault/keyvault-secrets/review/keyvault-secrets.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@
```ts

import { AzureLogger } from '@azure/logger';
import type * as coreClient from '@azure/core-client';
import type * as coreClient from '@azure-rest/core-client';
import type { ExtendedCommonClientOptions } from '@azure/core-http-compat';
import { PagedAsyncIterableIterator } from '@azure/core-paging';
import { PageSettings } from '@azure/core-paging';
import { PollerLike } from '@azure/core-lro';
import { PollOperationState } from '@azure/core-lro';
import type { PollOperationState } from '@azure/core-lro';
import type { TokenCredential } from '@azure/core-auth';

// @public
Expand Down
36 changes: 36 additions & 0 deletions sdk/keyvault/keyvault-secrets/src/generated/api/index.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

65 changes: 65 additions & 0 deletions sdk/keyvault/keyvault-secrets/src/generated/api/keyVaultContext.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit e336721

Please sign in to comment.