Skip to content

Commit

Permalink
[communication-rooms] Wait for PatchParticipants Rest API calls to co…
Browse files Browse the repository at this point in the history
…mplete before returning (#31889)

### Packages impacted by this PR
communication-rooms

### Issues associated with this PR

### Describe the problem that is addressed by this PR
'addOrUpdateParticipants' and 'removeParticipants' methods were missing
an await and the methods were returning before the task was getting
completed.

### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
N/A

### Are there test cases added in this PR? _(If not, why?)_
Existing test cases were modified

### Provide a list of related PRs _(if any)_
N/A

### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_

### Checklists
- [X] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [X] Added a changelog (if necessary)
  • Loading branch information
magesh-ms authored Dec 4, 2024
1 parent ef3f81c commit 77f300c
Show file tree
Hide file tree
Showing 10 changed files with 274 additions and 199 deletions.
6 changes: 6 additions & 0 deletions sdk/communication/communication-rooms/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Release History

## 1.1.1 (2024-11-22)

### Bugs Fixed

- Bug fix for 'addOrUpdateParticipants' and 'removeParticipants' methods to wait for the operation to complete before returning

## 1.1.0 (2024-04-15)

### Other Changes
Expand Down
2 changes: 1 addition & 1 deletion sdk/communication/communication-rooms/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"sdk-type": "client",
"author": "Microsoft Corporation",
"description": "Azure client library for Azure Communication Rooms services",
"version": "1.1.0",
"version": "1.1.1",
"engines": {
"node": ">=18.0.0"
},
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 77f300c

Please sign in to comment.