Skip to content

Commit

Permalink
[OpenAI] Skip failing deployment (#32053)
Browse files Browse the repository at this point in the history
- Skip failing deployment gpt-4 for JSON response format
- Increase test timeout for batch list tests
  • Loading branch information
minhanh-phan authored Dec 5, 2024
1 parent a1de480 commit 42eacf3
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 3 deletions.
3 changes: 2 additions & 1 deletion common/config/rush/pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 6 additions & 1 deletion sdk/openai/openai/test/public/completions.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,11 @@ import {
withDeployments,
} from "./utils/utils.js";
import { type ChatCompletionMessageParam } from "openai/resources/chat/completions.mjs";
import { completionsModelsToSkip, functionCallModelsToSkip } from "./utils/models.js";
import {
completionsModelsToSkip,
functionCallModelsToSkip,
jsonResponseModelsToSkip,
} from "./utils/models.js";
import "../../src/types/index.js";

describe("Completions", function () {
Expand Down Expand Up @@ -368,6 +372,7 @@ describe("Completions", function () {
assert.fail(`Invalid JSON: ${content}`);
}
},
jsonResponseModelsToSkip,
),
chatCompletionDeployments,
);
Expand Down
3 changes: 3 additions & 0 deletions sdk/openai/openai/test/public/utils/models.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,6 @@ export const ttsModelsToSkip = [{ name: "whisper", version: "001" }];

// TODO: Remove this when "completion_tokens" is consistently returned
export const completionsModelsToSkip = [{ name: "gpt-4", version: "0613" }];

// TODO: Remove this when "completion_tokens" is consistently returned
export const jsonResponseModelsToSkip = [{ name: "gpt-4", version: "0125-Preview" }];
2 changes: 1 addition & 1 deletion sdk/openai/openai/vitest.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export default mergeConfig(
viteConfig,
defineConfig({
test: {
testTimeout: 250000,
testTimeout: 300000,
hookTimeout: 25000,
fileParallelism: false,
include: ["test/public/**/*.spec.ts"],
Expand Down

0 comments on commit 42eacf3

Please sign in to comment.