[EngSys] upgrade dev dependency puppeteer to ^22.0.0 (#28200)

by running `rush add -m --dev -p puppeteer@^22.0.0` - adjust core-xml test due puppeteer switched from Chromium to Chrome - ignore Accept-Language headers for browser playback tests Resolves #25790
Azure · Feb 6, 2024 · 18d6d50 · 18d6d50
1 parent d0a773e
commit 18d6d50
Show file tree

Hide file tree

Showing 33 changed files with 192 additions and 297 deletions.
diff --git a/common/config/rush/pnpm-lock.yaml b/common/config/rush/pnpm-lock.yaml
diff --git a/sdk/core/core-amqp/package.json b/sdk/core/core-amqp/package.json
@@ -94,7 +94,7 @@
     "karma-mocha": "^2.0.1",
     "mocha": "^10.0.0",
     "c8": "^8.0.0",
-    "puppeteer": "^19.2.2",
+    "puppeteer": "^22.0.0",
     "rimraf": "^3.0.0",
     "sinon": "^17.0.0",
     "ts-node": "^10.0.0",

diff --git a/sdk/core/core-sse/package.json b/sdk/core/core-sse/package.json
@@ -82,7 +82,7 @@
     "karma-sourcemap-loader": "^0.3.8",
     "mocha": "^10.0.0",
     "c8": "^8.0.0",
-    "puppeteer": "^19.2.2",
+    "puppeteer": "^22.0.0",
     "rimraf": "^3.0.2",
     "ts-node": "^10.0.0",
     "typescript": "~5.3.3"

diff --git a/sdk/core/core-xml/test/xml.spec.ts b/sdk/core/core-xml/test/xml.spec.ts
@@ -11,11 +11,14 @@ describe("XML serializer", function () {
         // @ts-expect-error - intentional error for test
         await parseXML(undefined);
         assert.fail("Expected error");
-      } catch (error: any) {
+      } catch (err) {
+        assert.ok(err instanceof Error);
+        const error = err as Error;
         assert.ok(
-          error.message.indexOf("Document is empty") !== -1 || // Chrome
+          error.message.includes("Document is empty") || // NodeJS v8
+            error.message.includes("This page contains the following errors") || // Chrome
             (error.message.startsWith("XML Parsing Error: syntax error") &&
-              error.message.indexOf("undefined") !== -1), // Firefox
+              error.message.includes("undefined")), // Firefox
           `error.message ("${error.message}") should have contained "Document is empty" or "undefined"`,
         );
       }
@@ -26,11 +29,14 @@ describe("XML serializer", function () {
         // @ts-expect-error - intentional error for test
         await parseXML(null);
         assert.fail("Expected error");
-      } catch (error: any) {
+      } catch (err) {
+        assert.ok(err instanceof Error);
+        const error = err as Error;
         assert.ok(
-          error.message.indexOf("Document is empty") !== -1 || // Chrome
+          error.message.includes("Document is empty") || // NodeJS v8
+            error.message.includes("This page contains the following errors") || // Chrome
             (error.message.startsWith("XML Parsing Error: syntax error") &&
-              error.message.indexOf("null") !== -1), // Firefox
+              error.message.includes("null")), // Firefox
           `error.message ("${error.message}") should have contained "Document is empty" or "null"`,
         );
       }
@@ -442,24 +448,6 @@ describe("XML serializer", function () {
       );
     });
 
-    it("with element with attribute and value", async function () {
-      const xml = stringifyXML(
-        {
-          fruit: {
-            $: {
-              healthy: "true",
-            },
-            _: "yum",
-          },
-        },
-        { rootName: "fruits" },
-      );
-      assert.deepStrictEqual(
-        xml,
-        `<?xml version="1.0" encoding="UTF-8" standalone="yes"?><fruits><fruit healthy="true">yum</fruit></fruits>`,
-      );
-    });
-
     it("with element with child empty element", async function () {
       const xml = stringifyXML(
         {

diff --git a/sdk/core/logger/package.json b/sdk/core/logger/package.json
@@ -91,7 +91,7 @@
     "karma-sourcemap-loader": "^0.3.8",
     "mocha": "^10.0.0",
     "c8": "^8.0.0",
-    "puppeteer": "^19.2.2",
+    "puppeteer": "^22.0.0",
     "rimraf": "^3.0.0",
     "sinon": "^17.0.0",
     "ts-node": "^10.0.0",

diff --git a/sdk/core/ts-http-runtime/package.json b/sdk/core/ts-http-runtime/package.json
@@ -118,7 +118,7 @@
     "karma-sourcemap-loader": "^0.3.8",
     "karma": "^6.3.0",
     "mocha": "^10.0.0",
-    "puppeteer": "^19.2.2",
+    "puppeteer": "^22.0.0",
     "rimraf": "^3.0.0",
     "sinon": "^17.0.0",
     "typescript": "~5.3.3",

diff --git a/sdk/eventhub/event-hubs/package.json b/sdk/eventhub/event-hubs/package.json
@@ -151,7 +151,7 @@
     "mocha": "^10.0.0",
     "moment": "^2.24.0",
     "c8": "^8.0.0",
-    "puppeteer": "^19.2.2",
+    "puppeteer": "^22.0.0",
     "rimraf": "^3.0.0",
     "sinon": "^17.0.0",
     "ts-node": "^10.0.0",

diff --git a/sdk/identity/identity-broker/package.json b/sdk/identity/identity-broker/package.json
@@ -79,7 +79,7 @@
     "cross-env": "^7.0.2",
     "eslint": "^8.0.0",
     "mocha": "^10.0.0",
-    "puppeteer": "^20.5.0",
+    "puppeteer": "^22.0.0",
     "rimraf": "^5.0.1",
     "typescript": "~5.3.3",
     "sinon": "^17.0.0",

diff --git a/sdk/identity/identity-cache-persistence/package.json b/sdk/identity/identity-cache-persistence/package.json
@@ -82,7 +82,7 @@
     "eslint": "^8.0.0",
     "inherits": "^2.0.3",
     "mocha": "^10.0.0",
-    "puppeteer": "^19.2.2",
+    "puppeteer": "^22.0.0",
     "rimraf": "^3.0.0",
     "typescript": "~5.3.3",
     "util": "^0.12.1",

diff --git a/sdk/identity/identity-vscode/package.json b/sdk/identity/identity-vscode/package.json
@@ -80,7 +80,7 @@
     "eslint": "^8.0.0",
     "inherits": "^2.0.3",
     "mocha": "^10.0.0",
-    "puppeteer": "^19.2.2",
+    "puppeteer": "^22.0.0",
     "rimraf": "^3.0.0",
     "sinon": "^17.0.0",
     "typescript": "~5.3.3",

diff --git a/sdk/identity/identity/package.json b/sdk/identity/identity/package.json
@@ -154,7 +154,7 @@
     "mocha": "^10.0.0",
     "ms": "^2.1.3",
     "c8": "^8.0.0",
-    "puppeteer": "^19.2.2",
+    "puppeteer": "^22.0.0",
     "rimraf": "^3.0.0",
     "sinon": "^17.0.0",
     "ts-node": "^10.0.0",

diff --git a/sdk/keyvault/keyvault-certificates/package.json b/sdk/keyvault/keyvault-certificates/package.json
@@ -145,7 +145,7 @@
     "karma-sourcemap-loader": "^0.3.8",
     "mocha": "^10.0.0",
     "c8": "^8.0.0",
-    "puppeteer": "^19.2.2",
+    "puppeteer": "^22.0.0",
     "rimraf": "^3.0.0",
     "sinon": "^17.0.0",
     "source-map-support": "^0.5.9",

diff --git a/sdk/keyvault/keyvault-common/package.json b/sdk/keyvault/keyvault-common/package.json
@@ -72,7 +72,7 @@
     "esm": "^3.2.18",
     "mocha": "^10.0.0",
     "c8": "^8.0.0",
-    "puppeteer": "^19.2.2",
+    "puppeteer": "^22.0.0",
     "sinon": "^17.0.0",
     "source-map-support": "^0.5.9",
     "typescript": "~5.3.3",

diff --git a/sdk/keyvault/keyvault-keys/package.json b/sdk/keyvault/keyvault-keys/package.json
@@ -143,7 +143,7 @@
     "karma-sourcemap-loader": "^0.3.8",
     "mocha": "^10.0.0",
     "c8": "^8.0.0",
-    "puppeteer": "^19.2.2",
+    "puppeteer": "^22.0.0",
     "rimraf": "^3.0.0",
     "sinon": "^17.0.0",
     "source-map-support": "^0.5.9",

diff --git a/sdk/keyvault/keyvault-keys/test/public/keyClient.spec.ts b/sdk/keyvault/keyvault-keys/test/public/keyClient.spec.ts
@@ -17,6 +17,7 @@ import { testPollerProperties } from "./utils/recorderUtils";
 import { authenticate, envSetupForPlayback } from "./utils/testAuthentication";
 import TestClient from "./utils/testClient";
 import { stringToUint8Array, uint8ArrayToString } from "./utils/crypto";
+import { isBrowser } from "@azure/core-util";
 
 describe("Keys client - create, read, update and delete operations", () => {
   const keyPrefix = `CRUD${env.KEY_NAME || "KeyName"}`;
@@ -30,7 +31,7 @@ describe("Keys client - create, read, update and delete operations", () => {
 
     // These tests rely on the attestation URI inside the Release Policy, which is sanitized by the test recorder.
     // Using a bodiless matcher to ignore the differences that this causes.
-    recorder.setMatcher("BodilessMatcher");
+    await recorder.setMatcher("BodilessMatcher");
     await recorder.start(envSetupForPlayback);
 
     const authentication = await authenticate(getServiceVersion(), recorder);
@@ -263,7 +264,7 @@ describe("Keys client - create, read, update and delete operations", () => {
       "Unexpected key name in result from beginDeleteKey().",
     );
     await poller.pollUntilDone();
-    let getResult = await poller.getResult();
+    let getResult = poller.getResult();
     assert.equal(
       getResult!.name,
       keyName,
@@ -452,7 +453,12 @@ describe("Keys client - create, read, update and delete operations", () => {
       }
     });
 
-    it("can create an exportable key and release it", async () => {
+    it("can create an exportable key and release it", async function (this: Context) {
+      // Recorder sanitizer issue
+      // https://github.com/Azure/azure-sdk-for-js/issues/28455
+      if (isPlaybackMode() && isBrowser) {
+        this.skip();
+      }
       const keyName = recorder.variable(
         "exportkey",
         `exportkey-${Math.floor(Math.random() * 1000)}`,
@@ -499,7 +505,12 @@ describe("Keys client - create, read, update and delete operations", () => {
       );
     });
 
-    it("errors when updating an immutable release policy", async () => {
+    it("errors when updating an immutable release policy", async function (this: Context) {
+      // Recorder sanitizer issue
+      // https://github.com/Azure/azure-sdk-for-js/issues/28455
+      if (isPlaybackMode() && isBrowser) {
+        this.skip();
+      }
       const keyName = recorder.variable(
         "immutablerelease",
         `immutablerelease-${Math.floor(Math.random() * 1000)}`,

diff --git a/sdk/keyvault/keyvault-secrets/package.json b/sdk/keyvault/keyvault-secrets/package.json
@@ -138,7 +138,7 @@
     "karma-sourcemap-loader": "^0.3.8",
     "mocha": "^10.0.0",
     "c8": "^8.0.0",
-    "puppeteer": "^19.2.2",
+    "puppeteer": "^22.0.0",
     "rimraf": "^3.0.0",
     "sinon": "^17.0.0",
     "source-map-support": "^0.5.9",

diff --git a/sdk/notificationhubs/notification-hubs/package.json b/sdk/notificationhubs/notification-hubs/package.json
@@ -111,7 +111,7 @@
     "karma-mocha-reporter": "^2.2.5",
     "karma-sourcemap-loader": "^0.3.8",
     "mocha": "^10.0.0",
-    "puppeteer": "^19.2.2",
+    "puppeteer": "^22.0.0",
     "rimraf": "^5.0.5",
     "ts-node": "^10.9.1",
     "typescript": "~5.3.3",

diff --git a/sdk/openai/openai/package.json b/sdk/openai/openai/package.json
@@ -127,7 +127,7 @@
     "karma-sourcemap-loader": "^0.3.8",
     "mocha": "^10.0.0",
     "c8": "^8.0.0",
-    "puppeteer": "^19.2.2",
+    "puppeteer": "^22.0.0",
     "rimraf": "^3.0.2",
     "ts-node": "^10.0.0",
     "typescript": "~5.3.3"

diff --git a/sdk/servicebus/service-bus/package.json b/sdk/servicebus/service-bus/package.json
@@ -157,7 +157,7 @@
     "moment": "^2.24.0",
     "c8": "^8.0.0",
     "promise": "^8.0.3",
-    "puppeteer": "^19.2.2",
+    "puppeteer": "^22.0.0",
     "rimraf": "^3.0.0",
     "ts-node": "^10.0.0",
     "typescript": "~5.3.3",

diff --git a/sdk/storage/storage-blob-changefeed/package.json b/sdk/storage/storage-blob-changefeed/package.json
@@ -124,7 +124,7 @@
     "karma-sourcemap-loader": "^0.3.8",
     "mocha": "^10.0.0",
     "c8": "^8.0.0",
-    "puppeteer": "^19.2.2",
+    "puppeteer": "^22.0.0",
     "rimraf": "^3.0.0",
     "source-map-support": "^0.5.9",
     "ts-node": "^10.0.0",

diff --git a/sdk/storage/storage-blob/package.json b/sdk/storage/storage-blob/package.json
@@ -167,7 +167,7 @@
     "karma-sourcemap-loader": "^0.3.8",
     "mocha": "^10.0.0",
     "c8": "^8.0.0",
-    "puppeteer": "^19.2.2",
+    "puppeteer": "^22.0.0",
     "rimraf": "^3.0.0",
     "source-map-support": "^0.5.9",
     "ts-node": "^10.0.0",

diff --git a/sdk/storage/storage-file-datalake/package.json b/sdk/storage/storage-file-datalake/package.json
@@ -154,7 +154,7 @@
     "karma-sourcemap-loader": "^0.3.8",
     "mocha": "^10.0.0",
     "c8": "^8.0.0",
-    "puppeteer": "^19.2.2",
+    "puppeteer": "^22.0.0",
     "rimraf": "^3.0.0",
     "sinon": "^17.0.0",
     "source-map-support": "^0.5.9",

diff --git a/sdk/storage/storage-file-share/package.json b/sdk/storage/storage-file-share/package.json
@@ -159,7 +159,7 @@
     "karma-sourcemap-loader": "^0.3.8",
     "mocha": "^10.0.0",
     "c8": "^8.0.0",
-    "puppeteer": "^19.2.2",
+    "puppeteer": "^22.0.0",
     "rimraf": "^3.0.0",
     "sinon": "^17.0.0",
     "source-map-support": "^0.5.9",

diff --git a/sdk/storage/storage-internal-avro/package.json b/sdk/storage/storage-internal-avro/package.json
@@ -91,7 +91,7 @@
     "karma-sourcemap-loader": "^0.3.8",
     "mocha": "^10.0.0",
     "c8": "^8.0.0",
-    "puppeteer": "^19.2.2",
+    "puppeteer": "^22.0.0",
     "rimraf": "^3.0.0",
     "source-map-support": "^0.5.9",
     "ts-node": "^10.0.0",

diff --git a/sdk/storage/storage-queue/package.json b/sdk/storage/storage-queue/package.json
@@ -150,7 +150,7 @@
     "karma-sourcemap-loader": "^0.3.8",
     "mocha": "^10.0.0",
     "c8": "^8.0.0",
-    "puppeteer": "^19.2.2",
+    "puppeteer": "^22.0.0",
     "rimraf": "^3.0.0",
     "source-map-support": "^0.5.9",
     "ts-node": "^10.0.0",

diff --git a/sdk/template/template-dpg/package.json b/sdk/template/template-dpg/package.json
@@ -104,7 +104,7 @@
     "karma-sourcemap-loader": "^0.3.8",
     "mocha": "^10.0.0",
     "c8": "^8.0.0",
-    "puppeteer": "^19.2.2",
+    "puppeteer": "^22.0.0",
     "rimraf": "^3.0.2",
     "ts-node": "^10.0.0",
     "typescript": "~5.3.3",

diff --git a/sdk/test-utils/recorder/CHANGELOG.md b/sdk/test-utils/recorder/CHANGELOG.md
@@ -19,7 +19,7 @@
   - Clarify error when attempting to redirect a request but the recorder has not been started
   - Forward mismatch error when recording file cannot be found during `start` call in playback mode
   - Add more descriptive message in the case that the test proxy has not been started before running the tests
-
+- Ignore `Accept-Language` header for browsers in Playback mode.
 ## 3.0.0 (2023-03-07)
 
 ### Features Added