Skip to content

Sync eng/common directory with azure-sdk-tools for PR 10694 #45429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

azure-sdk
Copy link
Collaborator

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#10694 See eng/common workflow

@Copilot Copilot AI review requested due to automatic review settings May 21, 2025 18:40
@azure-sdk azure-sdk requested a review from a team as a code owner May 21, 2025 18:40
@azure-sdk azure-sdk requested a review from benbp May 21, 2025 18:40
@azure-sdk azure-sdk added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels May 21, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR synchronizes the eng/common directory with the latest changes from azure-sdk-tools, as referenced by PR 10694. The update mainly modifies the repository root path resolution in the common.ps1 script.

  • Update the repository root relative path from 4-level up (using backslashes) to a 3-level up path (using forward slashes).
Comments suppressed due to low confidence (1)

eng/common/scripts/common.ps1:3

  • Verify that the change to a 3-level up relative path correctly resolves to the intended repository root, as the previous implementation used 4 levels up.
$RepoRoot = Resolve-Path "${PSScriptRoot}/../../../"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants