Adding effective ReadConsistencyStrategy to CosmosDiagnosticsContext #45414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
The purpose of this PR is to add support for an effective ReadConsistencyStrategy in CosmosDiagnosticsContext and related diagnostics code.
- Added a new ReadConsistencyStrategy parameter to methods that create or manipulate CosmosDiagnosticsContext.
- Updated FeedOperationState, DiagnosticsProvider, CosmosAsyncContainer, and CosmosAsyncClient to incorporate read consistency strategy logic.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ImplementationBridgeHelpers.java | Added ReadConsistencyStrategy parameter to create method and interface definition. |
| FeedOperationState.java | Extracted and computed effective read consistency strategy from request options. |
| DiagnosticsProvider.java | Propagated read consistency strategy from request options to diagnostics context. |
| CosmosDiagnosticsContext.java | Stored and exposed the read consistency strategy with added null-check and toString logging. |
| CosmosAsyncContainer.java | Passed effective read consistency strategy from request options into policy application. |
| CosmosAsyncClient.java | Added logic for determining effective read consistency strategy under various conditions. |
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosDiagnosticsContext.java
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosAsyncClient.java
Show resolved
Hide resolved
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
|
/azp run java - cosmos - tests |
1 similar comment
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - cosmos - tests |
|
/azp run java - cosmos - kafka |
|
/azp run java - cosmos - spark |
|
Azure Pipelines successfully started running 1 pipeline(s). |
2 similar comments
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
xinlian12
reviewed
May 21, 2025
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RxDocumentClientImpl.java
Show resolved
Hide resolved
xinlian12
reviewed
May 21, 2025
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/RxGatewayStoreModel.java
Show resolved
Hide resolved
xinlian12
reviewed
May 21, 2025
...e-cosmos-benchmark/src/test/java/com/azure/cosmos/benchmark/ReadMyWritesConsistencyTest.java
Show resolved
Hide resolved
|
/azp run java - cosmos - tests |
|
/azp run java - cosmos - kafka |
|
/azp run java - cosmos - spark |
|
Azure Pipelines successfully started running 1 pipeline(s). |
2 similar comments
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
nehrao1
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds information about the effective read consistency startegy used to the
CosmosDiagnosticsContextto improve diagnostics. It also fixes a few test issues (flakiness etc.) identified in the CI pipeline executions validating the change.All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines