Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Live Metrics Filtering Part 5: Validator #43506

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

Live Metrics Filtering Part 5: Validator #43506

wants to merge 24 commits into from

Conversation

harsimar
Copy link
Member

Description

This PR adds code to validate the config, and some tests. Only valid config is saved in FilteringConfiguration.java.
Added some unit tests for the validator & manually tested this end to end.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

harsimar added 24 commits December 9, 2024 16:38
@harsimar
adding projection functionality, rethink automic double
4aa78d3
@harsimar
atomic double and some other changes
bf15276
@harsimar
merge from master to get p3 changes
4ace19d
@harsimar
pr comments and some build stuff
75718c7
@harsimar
changing guava version
27d4979
@harsimar
spotbug fix
619bb47
@harsimar
starting to add tests
915d579
@harsimar
added unit tests for derived metric projection
9c8fa37
@harsimar
fix conflict from main
e3377d7
@harsimar
reorganize tests
c599211
@harsimar
fixing inconsistency with main re okio
a6ab936
@harsimar
pr comments & small refactorings
494a1b9
@harsimar
remove logging, spotless
1351d2b
@harsimar
validator
a77adfe
@harsimar
minor
68b9c83
@harsimar
changes to concurrency handling
d80053e
@harsimar
moving synchronization to derivedMetricAggregation
f83c116
@harsimar
moving derivedMetricAggregation to its own file
d8b618f
@harsimar
merge projection into here
77f176a
@harsimar
validator round 1 - need to refactor for validator to store errors
96e705f
@harsimar
finish implementation and starting to add tests
6e81b55
@harsimar
merge from main
568f059
@harsimar
spotless
de6bd93
@harsimar
remove unused classes
f492237
@github-actions github-actions bot added the OpenTelemetry OpenTelemetry instrumentation label Dec 20, 2024
@harsimar harsimar marked this pull request as ready for review December 20, 2024 00:10
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask Awaiting requested review from trask trask is a code owner

@ramthi ramthi Awaiting requested review from ramthi ramthi is a code owner

@heyams heyams Awaiting requested review from heyams heyams is a code owner

@jeanbisutti jeanbisutti Awaiting requested review from jeanbisutti jeanbisutti is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
OpenTelemetry OpenTelemetry instrumentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harsimar @azure-sdk