[OpenAI] Improved logging and specific handlers #43460
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API change check API changes are not detected in this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Writing a sample for this library, I noticed a lot of issues with logging and with keep-alive timeouts:
AtomicReference<ClientLogger>types, as it didn't seem to contribute into anything. Usingprivate static final ClientLoggerinsteadatVerboseand better exception handling with the client loggerI run into several issues developing the sample hitting the public OpenAI realtime WSS endpoint, however using the Azure one made things work well for me. I thought the improvements introduced in this PR, even though they didn't solve anything in the end, are valuable moving forward.