Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stumpaudra/fleet member bump #32310

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

audrastump
Copy link
Member

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

Click here to open a PR for only SDK configuration.

Copy link

openapi-pipeline-app bot commented Jan 24, 2025

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This is the public specs repo main branch which is not intended for iterative development.
    You must acknowledge that you understand that after this PR is merged, you won't be able to stop your changes from being published to Azure customers.
    If this is what you intend, add PublishToCustomers label to your PR.
    Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ This PR has at least one change violating Azure versioning policy (label: VersioningReviewRequired).
    To unblock this PR, either a) introduce a new API version with these changes instead of modifying an existing API version, or b) follow the process at aka.ms/brch.
  • ❌ The required check named Swagger PrettierCheck has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide

Copy link

openapi-pipeline-app bot commented Jan 24, 2025

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/containerservicefleet/armcontainerservicefleet There is no API change compared with the previous version
JavaScript @azure/arm-containerservicefleet https://apiview.dev/Assemblies/Review/65c668ceaa2346708bf1e479b7f6b79b?revisionId=bc445cc837df4aa2b560aa785506aaa0
Python azure-mgmt-containerservicefleet https://apiview.dev/Assemblies/Review/e0444ab348814233b7add2d104e5bcaa?revisionId=87ca2ba2bc6b4626af2eefd99fce070d
.Net Azure.ResourceManager.ContainerServiceFleet https://apiview.dev/Assemblies/Review/9aa3ea8f347d4034b2a82a35e6d18a18?revisionId=b5b8dcf2f43f4ce292735c96fedbae81
TypeSpec Fleet.Management https://apiview.dev/Assemblies/Review/07108f7e68af4cd597d04c921b7282b8?revisionId=f28901e7959a4f7d89784227647bb0d0

@azure-sdk
Copy link
Collaborator

azure-sdk commented Jan 24, 2025

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.ContainerService-fleet
Microsoft.ContainerService

@AzureRestAPISpecReview AzureRestAPISpecReview removed the VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required label Jan 28, 2025
@AzureRestAPISpecReview AzureRestAPISpecReview added the VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required label Jan 28, 2025
@AzureRestAPISpecReview AzureRestAPISpecReview added VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required and removed VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required labels Jan 28, 2025
@audrastump audrastump force-pushed the stumpaudra/fleetMemberBump branch from bcf4194 to 9bce78c Compare January 28, 2025 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Container Service resource-manager TypeSpec Authored with TypeSpec VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants