Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release machinelearningservices microsoft.machine learning services 2025 01 01 preview #32279

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

ZhidaLiu
Copy link
Member

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

ragovada and others added 13 commits November 18, 2024 15:13
Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.
Updated the API version from preview/2024-10-01-preview to preview/2025-01-01-preview.
…e#32002)

* Add ActualCapacityInfo contract changes to 2025 preview

* Making updates to ActualCapacityInfo for Group Status
* Add quota apis

* add location in swagger

* add list available quota

* add AvailableQuotaArmPaginatedResult

* add location param

* location param in examples

* replace with location parameters

* Removes azure-resource-manager-schemas from SDK automation. It can be re-added without reverting this commit. (Azure#30893) (Azure#31918)

This change produces an extra warning but no obvious new errors.

---------

Co-authored-by: Daniel Jurek <[email protected]>
* merge change from 2024-10-01-preview

* add bugfix changes and new list api

* Removes azure-resource-manager-schemas from SDK automation. It can be re-added without reverting this commit. (Azure#30893) (Azure#31918)

This change produces an extra warning but no obvious new errors.

---------

Co-authored-by: Daniel Jurek <[email protected]>
…Azure#32030)

* Update mfe.json to add new content safety level property

* prettier

* more prettier

* Update createOrUpdate.json with contentsafetylevel

* Update get.json

* Update list.json

* Update update.json
* Update mfe.json

* Update mfe.json

* Update mfe.json

* Update mfe.json

* Update mfe.json

* Update mfe.json

* Update mfe.json

* Update mfe.json
* add parent job name

add parent job name

* prettier

prettier

* prettier

prettier
* add aad auth mode and cherrypick

* prettier

* remove getStatus change

* reset mfe, add back aad auth

* revert getStatus

* prettier cmd

* update mfe

* prettier

* cherrypick commit 1fc2fa1

* add newline back

* add newline back
Copy link

PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.

Copy link

openapi-pipeline-app bot commented Jan 22, 2025

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR has ARMChangesRequested label. Please address or respond to feedback from the ARM API reviewer.
    When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
    Automation should then add WaitForARMFeedback label.
    ❗If you don't have permissions to remove the label, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories.
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review
  • ❌ The required check named Swagger LintDiff has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide

Copy link

openapi-pipeline-app bot commented Jan 22, 2025

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/machinelearning/armmachinelearning There is no API change compared with the previous version
Java azure-resourcemanager-machinelearning https://apiview.dev/Assemblies/Review/e1c428cb12c840a2b15ad2ba61d138e7?revisionId=a4732359dd6c468799078efb114fb64b
JavaScript @azure/arm-machinelearning https://apiview.dev/Assemblies/Review/4b0822cc790d43b3b46bc9b075044246?revisionId=3a5e7b6f86e140fca6fe1539f001ff46
.Net Azure.ResourceManager.MachineLearning https://apiview.dev/Assemblies/Review/b3a1424a42c346a8906822f457909b53?revisionId=a0f8a1cea3744af5b131c64d58a14667

@ZhidaLiu ZhidaLiu marked this pull request as ready for review January 22, 2025 18:45
@github-actions github-actions bot added the brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. label Jan 22, 2025
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.MachineLearningServices

* Lint diff fixes for Jan 25 preview

* Update tag

* Keep tag format consistent with other versions

* resolve merge conflicts

---------

Co-authored-by: ZhidaLiu <[email protected]>
@ZhidaLiu ZhidaLiu added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Jan 27, 2025
@ZhidaLiu
Copy link
Member Author

/azp run

Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@AzureRestAPISpecReview AzureRestAPISpecReview added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed NotReadyForARMReview labels Jan 27, 2025
@ZhidaLiu ZhidaLiu removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 27, 2025
@ZhidaLiu
Copy link
Member Author

/azp run

Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

ZhidaLiu and others added 2 commits January 27, 2025 14:04
* Distillation ARM changes

* Fix CSPell check

* Fixed Prettier Failures

* Fixed Model Validation

* Updated PromptSetting description

* Added Only Distillation Changes

* Added definitions

* removed unwanted changes

* Ran Prettier

* Updated swagger based on Vienna review

* Updated Examples

* Updated Description for Prompt Setting

* Reorganized as per review comments

* Updated examples

* Ran Prettier

* Handled review comments

* Added Suppression.yaml file

* Updated syntax

* Fixed syntax

* Added Suppressions in readme

---------

Co-Authored-By: Qiaoqiao Zhang <[email protected]>
@gary-x-li
Copy link
Contributor

Please fix the Swagger LintDiff errors first.

Also, the original PR doesn't seem to be reviewed/approved by ARM. It only has the breaking change approval.

@gary-x-li gary-x-li added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jan 29, 2025
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review ARMReview BreakingChange-Approved-Previously Changes were reviewed and approved in a previous PR BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. new-api-version PublishToCustomers Acknowledgement the changes will be published to Azure customers. resource-manager SuppressionReviewRequired
Projects
None yet
Development

Successfully merging this pull request may close these issues.