Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add recipientMailServerHostName to AcsEmailDeliveryReportStatusDetails of AcsEmailDeliveryReportReceivedEventData and InternetMessageId to AcsEmailDeliveryReportReceivedEventData #31739

Merged
merged 25 commits into from
Jan 16, 2025

Conversation

fanruisun
Copy link
Contributor

add recipient Mail server to AcsEmailDeliveryReportStatusDetails

@fanruisun fanruisun requested a review from Kishp01 as a code owner December 3, 2024 23:07
Copy link

openapi-pipeline-app bot commented Dec 3, 2024

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This is the public specs repo main branch which is not intended for iterative development.
    You must acknowledge that you understand that after this PR is merged, you won't be able to stop your changes from being published to Azure customers.
    If this is what you intend, add PublishToCustomers label to your PR.
    Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ The required check named SDK azure-sdk-for-go has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide. In addition, refer to step 3 in the PR workflow diagram

Copy link

openapi-pipeline-app bot commented Dec 3, 2024

Generated ApiView

Language Package Name ApiView Link
.Net Azure.Messaging.EventGrid.SystemEvents https://apiview.dev/Assemblies/Review/3e102a891e5445af8be8cde833dbb702?revisionId=5d1f903681c24c7682885f6aab1f7208
Python azure-eventgrid https://apiview.dev/Assemblies/Review/c554ddbabc6e40348998b1656e0ff585?revisionId=1eee3b6d50cb4eae9e5ec2f9f6c5b1a4
TypeSpec Azure.Messaging.EventGrid.SystemEvents Create ApiView failed. To get help, please see [aka.ms/azsdk/pr-getting-help](https://aka.ms/azsdk/pr-getting-help).

@azure-sdk
Copy link
Collaborator

azure-sdk commented Dec 3, 2024

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.ApiCenter

@github-actions github-actions bot added the brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. label Dec 12, 2024
@fanruisun fanruisun changed the title add recipient Mail server add recipient Mailerver to AcsEmailDeliveryReportStatusDetails Dec 13, 2024
@fanruisun fanruisun changed the title add recipient Mailerver to AcsEmailDeliveryReportStatusDetails add recipientMailServer to AcsEmailDeliveryReportStatusDetails of Dec 13, 2024
@fanruisun fanruisun changed the title add recipientMailServer to AcsEmailDeliveryReportStatusDetails of add recipientMailServer to AcsEmailDeliveryReportStatusDetails of AcsEmailDeliveryReportReceivedEventData and InternetMessageId to AcsEmailDeliveryReportReceivedEventData Dec 13, 2024
@AzureRestAPISpecReview AzureRestAPISpecReview added the TypeSpec Authored with TypeSpec label Dec 13, 2024
@fanruisun
Copy link
Contributor Author

add recipientMailServer to AcsEmailDeliveryReportStatusDetails of AcsEmailDeliveryReportReceivedEventData
add InternetMessageId to AcsEmailDeliveryReportReceivedEventData

@AzureRestAPISpecReview AzureRestAPISpecReview added the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Dec 17, 2024
@tadelesh
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@fanruisun fanruisun changed the title add recipientMailServer to AcsEmailDeliveryReportStatusDetails of AcsEmailDeliveryReportReceivedEventData and InternetMessageId to AcsEmailDeliveryReportReceivedEventData add recipientMailServerHostName to AcsEmailDeliveryReportStatusDetails of AcsEmailDeliveryReportReceivedEventData and InternetMessageId to AcsEmailDeliveryReportReceivedEventData Dec 19, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the no-recent-activity There has been no recent activity on this issue. label Jan 6, 2025
@lmazuel lmazuel added BreakingChange-Approved-Benign Changes are not breaking at the REST API level and have at most minor impact to generated SDKs. and removed BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required labels Jan 16, 2025
@lmazuel lmazuel merged commit c18f249 into Azure:main Jan 16, 2025
23 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BreakingChange-Approved-Benign Changes are not breaking at the REST API level and have at most minor impact to generated SDKs. brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. data-plane Event Grid TypeSpec Authored with TypeSpec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants