[PS Reservation] Fixed purchase request missing update x-ms-mutability for location #27958
+54
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
vidai-msft
requested changes
Jun 13, 2025
dolauli
approved these changes
Jun 17, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR ensures the location property in the PurchaseRequest schema is marked as updatable in Autorest, bumps the module version, and cleans up typos across docs and examples.
- Added an Autorest directive to include
"update"inx-ms-mutabilityforlocation. - Corrected spelling errors (
qualified,truncated,properties) in examples and docs. - Bumped the module version in
AssemblyInfo.cs, updated the release date in the manifest, and added a ChangeLog entry.
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Reservations/Reservations.Autorest/README.md | Added transform to set x-ms-mutability to ["read","update","create"] for location |
| src/Reservations/Reservations.Autorest/examples/*.md | Fixed typos: “qulified” → “qualified”, “trucated” → “truncated” |
| src/Reservations/Reservations/ChangeLog.md | Added upcoming release note about mutability fix |
| src/Reservations/Reservations.Autorest/Properties/AssemblyInfo.cs | Bumped AssemblyVersion and FileVersion to 0.14.0 |
| src/Reservations/Reservations/Az.Reservations.psd1 | Updated # Generated on date and bumped Az.Accounts dependency version |
Comments suppressed due to low confidence (1)
src/Reservations/Reservations.Autorest/README.md:58
- Because the property name contains a hyphen, switch to bracket notation (e.g.,
['x-ms-mutability']) in the JSON path to ensure Autorest correctly matches thex-ms-mutabilityproperty.
where: $.definitions.PurchaseRequest.properties.location.x-ms-mutability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.