-
Notifications
You must be signed in to change notification settings - Fork 4k
NetworkCloud 2025-02-01 Stable API : powershell updates #27724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
@@ -19,6 +19,9 @@ | |||
--> | |||
## Upcoming Release | |||
|
|||
## Version 1.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version likely needs an update . e.g 1.2.0, will need to confirm on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bumped to 1.2.0
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Please fix the failed checks |
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
…8/azure-powershell into networkcloud-2025-02-01
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Please fix the failed checks |
Can we get some help/pointers on how to proceed with the failures we are seeing in the CI please? |
@priyamshet please refer to the error messages above to fix the examples in the help docs of the cmdlets above |
[CmdletBinding(PositionalBinding=$false)] | ||
Param( | ||
|
||
[Parameter(HelpMessage="The association of IP address pools to the communities and peers, allowing for announcement of IPs.")] | ||
[Microsoft.Azure.PowerShell.Cmdlets.NetworkCloud.Models.Api20240701.IBgpAdvertisement[]] | ||
[Microsoft.Azure.PowerShell.Cmdlets.NetworkCloud.Models.Api20250201.IBgpAdvertisement[]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is reported that the type is unable to find. Could you check again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This property does exist in the swagger spec https://github.com/Azure/azure-rest-api-specs/blob/1ca714a9d53e37f86b4dabb9dfb9365233fe9da0/specification/networkcloud/resource-manager/Microsoft.NetworkCloud/stable/2025-02-01/networkcloud.json#L8047
Should we be checking something else for this issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be updated with the latest changes - before this point the 20240701 module was still being generated instead of 20250201, which is why the type couldn't be found.
} | ||
$securePassword = ConvertTo-SecureString "password" -asplaintext -force | ||
$identityUserAssignedIdentity = @{} | ||
$identityUserAssignedIdentity.Add(userAssignedIdentityResourceId, @{}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$identityUserAssignedIdentity.Add(userAssignedIdentityResourceId, @{}) | |
$identityUserAssignedIdentity.Add($userAssignedIdentityResourceId, @{}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made this change and also added dummy value for $identityUserAssignedIdentity
} | ||
$securePassword = ConvertTo-SecureString "password" -asplaintext -force | ||
$identityUserAssignedIdentity = @{} | ||
$identityUserAssignedIdentity.Add(userAssignedIdentityResourceId, @{}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$identityUserAssignedIdentity.Add(userAssignedIdentityResourceId, @{}) | |
$identityUserAssignedIdentity.Add($userAssignedIdentityResourceId, @{}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made this change and also added dummy value for $identityUserAssignedIdentity
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
@annapankiewicz There are 2 issues detected in the Static Analysis stage. For the breaking change issue, we will reply in the Teams channel. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Az.NetworkCloud module to support the new 2025-02-01 stable API version. It revises recording files and test scripts for the cluster version update and continue version update operations by updating API endpoints, resource group/cluster names, target version values, and error handling.
Reviewed Changes
Copilot reviewed 156 out of 324 changed files in this pull request and generated no comments.
File | Description |
---|---|
src/NetworkCloud/NetworkCloud.Autorest/test/Invoke-AzNetworkCloudClusterVersionUpdate.Recording.json | Updated API endpoints and payload parameters including targetClusterVersion and Content-Length to reflect the new API version. |
src/NetworkCloud/NetworkCloud.Autorest/test/Invoke-AzNetworkCloudClusterContinueVersionUpdate.Tests.ps1 | Modified test parameters by switching to the continue update resource group and cluster names, and updated the expected error message while removing the skip flag. |
src/NetworkCloud/NetworkCloud.Autorest/test/Invoke-AzNetworkCloudClusterContinueVersionUpdate.Recording.json | Added a new recording for continue version updates with updated headers and API version details. |
@annapankiewicz Please fix the test failure issue. |
Here is the list of the static analysis that is also related to the test failure. |
@@ -14,3 +14,56 @@ | |||
"Az.NetworkCloud","New-AzNetworkCloudVirtualMachinePlacementHintObject","New-AzNetworkCloudVirtualMachinePlacementHintObject","1","8100","New-AzNetworkCloudVirtualMachinePlacementHintObject Does not support ShouldProcess but the cmdlet verb New indicates that it should.","Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue" | |||
"Az.NetworkCloud","New-AzNetworkCloudIpAddressPoolObject","New-AzNetworkCloudIpAddressPoolObject","1","8100","New-AzNetworkCloudIpAddressPoolObject Does not support ShouldProcess but the cmdlet verb New indicates that it should.","Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue" | |||
"Az.NetworkCloud","New-AzNetworkCloudBareMetalMachineConfigurationDataObject","New-AzNetworkCloudBareMetalMachineConfigurationDataObject","1","8100","New-AzNetworkCloudBareMetalMachineConfigurationDataObject Does not support ShouldProcess but the cmdlet verb New indicates that it should.","Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue" | |||
"Az.NetworkCloud","Get-AzNetworkCloudAgentPool","Get-AzNetworkCloudAgentPool","2","8010","Get-AzNetworkCloudAgentPool Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute.","Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where were these signature issues from? Were they warnings or errors? If warning, then please remove them and no need to suppress.
Hey @vidai-msft, thank you! I'm primary DRI for my team right now so I will get to these fully on Monday. I am confused about the breaking change errors though - wouldn't the property renames in our README.md fix the property/parameter breaking change errors? I followed the property name docs as directed, so not sure why the error is still occurring
|
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.General availability of Az.NetworkCloud module with 2025-02-01 API version
Deploy-AzNetworkCloudCluster
Disable-AzNetworkCloudStorageApplianceRemoteVendo…
Enable-AzNetworkCloudStorageApplianceRemoteVendor…
Get-AzNetworkCloudAgentPool
Get-AzNetworkCloudBareMetalMachine
Get-AzNetworkCloudBareMetalMachineKeySet
Get-AzNetworkCloudBmcKeySet
Get-AzNetworkCloudCluster
Get-AzNetworkCloudClusterManager
Get-AzNetworkCloudConsole
Get-AzNetworkCloudKubernetesCluster
Get-AzNetworkCloudKubernetesClusterFeature
Get-AzNetworkCloudL2Network
Get-AzNetworkCloudL3Network
Get-AzNetworkCloudMetricsConfiguration
Get-AzNetworkCloudRack
Get-AzNetworkCloudRackSku
Get-AzNetworkCloudServicesNetwork
Get-AzNetworkCloudStorageAppliance
Get-AzNetworkCloudTrunkedNetwork
Get-AzNetworkCloudVirtualMachine
Get-AzNetworkCloudVolume
Invoke-AzNetworkCloudBareMetalMachineCordon
Invoke-AzNetworkCloudBareMetalMachineDataExtract
Invoke-AzNetworkCloudBareMetalMachineReimage
Invoke-AzNetworkCloudBareMetalMachineReplace
Invoke-AzNetworkCloudBareMetalMachineRunCommand
Invoke-AzNetworkCloudBareMetalMachineRunReadComma…
Invoke-AzNetworkCloudBareMetalMachineUncordon
Invoke-AzNetworkCloudClusterContinueVersionUpdate
Invoke-AzNetworkCloudClusterVersionUpdate
Invoke-AzNetworkCloudScanClusterRuntime
Invoke-AzNetworkCloudVirtualMachineReimage
New-AzNetworkCloudAgentPool
New-AzNetworkCloudBareMetalMachineConfigurationDa…
New-AzNetworkCloudBareMetalMachineKeySet
New-AzNetworkCloudBgpAdvertisementObject
New-AzNetworkCloudBgpServiceLoadBalancerConfigura…
New-AzNetworkCloudBmcKeySet
New-AzNetworkCloudCluster
New-AzNetworkCloudClusterManager
New-AzNetworkCloudConsole
New-AzNetworkCloudControlPlaneNodeConfigurationOb…
New-AzNetworkCloudEgressEndpointObject
New-AzNetworkCloudEndpointDependencyObject
New-AzNetworkCloudInitialAgentPoolConfigurationOb…
New-AzNetworkCloudIpAddressPoolObject
New-AzNetworkCloudKeySetUserObject
New-AzNetworkCloudKubernetesCluster
New-AzNetworkCloudKubernetesClusterFeature
New-AzNetworkCloudL2Network
New-AzNetworkCloudL3Network
New-AzNetworkCloudL3NetworkAttachmentConfiguratio…
New-AzNetworkCloudMetricsConfiguration
New-AzNetworkCloudNetworkAttachmentObject
New-AzNetworkCloudRackDefinitionObject
New-AzNetworkCloudServiceLoadBalancerBgpPeerObject
New-AzNetworkCloudServicesNetwork
New-AzNetworkCloudStorageApplianceConfigurationDa…
New-AzNetworkCloudTrunkedNetwork
New-AzNetworkCloudVirtualMachine
New-AzNetworkCloudVirtualMachinePlacementHintObje…
New-AzNetworkCloudVolume
Remove-AzNetworkCloudAgentPool
Remove-AzNetworkCloudBareMetalMachineKeySet
Remove-AzNetworkCloudBmcKeySet
Remove-AzNetworkCloudCluster
Remove-AzNetworkCloudClusterManager
Remove-AzNetworkCloudConsole
Remove-AzNetworkCloudKubernetesCluster
Remove-AzNetworkCloudKubernetesClusterFeature
Remove-AzNetworkCloudL2Network
Remove-AzNetworkCloudL3Network
Remove-AzNetworkCloudMetricsConfiguration
Remove-AzNetworkCloudServicesNetwork
Remove-AzNetworkCloudTrunkedNetwork
Remove-AzNetworkCloudVirtualMachine
Remove-AzNetworkCloudVolume
Restart-AzNetworkCloudBareMetalMachine
Restart-AzNetworkCloudKubernetesClusterNode
Restart-AzNetworkCloudVirtualMachine
Start-AzNetworkCloudBareMetalMachine
Start-AzNetworkCloudVirtualMachine
Stop-AzNetworkCloudBareMetalMachine
Stop-AzNetworkCloudVirtualMachine
Update-AzNetworkCloudAgentPool
Update-AzNetworkCloudBareMetalMachine
Update-AzNetworkCloudBareMetalMachineKeySet
Update-AzNetworkCloudBmcKeySet
Update-AzNetworkCloudCluster
Update-AzNetworkCloudClusterManager
Update-AzNetworkCloudConsole
Update-AzNetworkCloudKubernetesCluster
Update-AzNetworkCloudKubernetesClusterFeature
Update-AzNetworkCloudL2Network
Update-AzNetworkCloudL3Network
Update-AzNetworkCloudMetricsConfiguration
Update-AzNetworkCloudRack
Update-AzNetworkCloudServicesNetwork
Update-AzNetworkCloudStorageAppliance
Update-AzNetworkCloudTrunkedNetwork
Update-AzNetworkCloudVirtualMachine
Update-AzNetworkCloudVolume