Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various issues reported by address sanitizer reported from the unit tests #768

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

robertwoj-microsoft
Copy link
Contributor

@robertwoj-microsoft robertwoj-microsoft commented Oct 11, 2024

Description

The following changes fix miscellaneous issues detected by the address sanitizer in the unit tests.

Checklist

  • I have read the contribution guidelines.
  • All unit tests are passing.
  • I have merged the latest main branch prior to this PR submission.
  • I submitted this PR against the main branch.

@robertwoj-microsoft robertwoj-microsoft requested a review from a team as a code owner October 11, 2024 11:43
@robertwoj-microsoft
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Microsoft"

@MariusNi
Copy link
Contributor

MariusNi commented Oct 11, 2024

@robertwoj-microsoft, please add a description to the PR (in place of the guidance: 'Describe your changes in as much detail as possible. Provide a link/reference to the issue solved with this request if any.').

Also, since this PR does not add any unit-tests, update that template check to only say: 'All unit tests are passing.' (cut: 'I added unit-tests to validate my changes. '). Because of the nature of change, not adding new unit-tests is acceptable. #Closed

Copy link
Contributor

@MariusNi MariusNi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@MariusNi MariusNi merged commit bd2af18 into Azure:main Oct 15, 2024
130 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants