Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing ASB v2's auditEnsureSystemdJournaldServicePersistsLogMessages and remediateEnsureSystemdJournaldServicePersistsLogMessages #764

Merged
merged 17 commits into from
Sep 17, 2024
Merged

Fixing ASB v2's auditEnsureSystemdJournaldServicePersistsLogMessages and remediateEnsureSystemdJournaldServicePersistsLogMessages #764

merged 17 commits into from
Sep 17, 2024

Conversation

MariusNi
Copy link
Contributor

@MariusNi MariusNi commented Sep 14, 2024 •
edited
Loading

Description

Fixing ASB v2's auditEnsureSystemdJournaldServicePersistsLogMessages and remediateEnsureSystemdJournaldServicePersistsLogMessages and adding detection (for now, just with tracing, ASB customization if any to come in later) for Azure Commodore.

Checklist

  • I have read the contribution guidelines.
  • All unit tests are passing.
  • I have merged the latest main branch prior to this PR submission.
  • I submitted this PR against the main branch.

@MariusNi MariusNi requested a review from a team as a code owner September 14, 2024 00:36
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 14, 2024 •
edited
Loading

Test Results

 44 files  ±0   44 suites  ±0   40m 1s ⏱️ + 1m 32s
  4 tests ±0    4 ✅ ±0   0 💤 ±0  0 ❌ ±0 
176 runs  ±0  154 ✅ ±0  22 💤 ±0  0 ❌ ±0 

Results for commit aecca29. ± Comparison against base commit 0b85ead.

♻️ This comment has been updated with latest results.

AhmedBM
AhmedBM approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@AhmedBM AhmedBM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@MariusNi MariusNi changed the title Adding a patch for SSH Posture Control to try to unblock new SSH port with SELinux Fixing ASB v2's auditEnsureSystemdJournaldServicePersistsLogMessages and remediateEnsureSystemdJournaldServicePersistsLogMessages Sep 17, 2024
@MariusNi MariusNi merged commit 043878e into main Sep 17, 2024
131 checks passed
@MariusNi MariusNi deleted the MariusNi/OsConfig_SSH_Sep14_2024 branch September 17, 2024 16:15
AhmedBM
AhmedBM approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@AhmedBM AhmedBM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AhmedBM AhmedBM AhmedBM approved these changes

@robertschaedler3 robertschaedler3 robertschaedler3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MariusNi @AhmedBM @robertschaedler3