Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Continuing stabilization for ASB v2 audit and remediation #706

Merged
merged 7 commits into from
Jun 4, 2024
Merged

Continuing stabilization for ASB v2 audit and remediation #706

merged 7 commits into from
Jun 4, 2024

Conversation

MariusNi
Copy link
Contributor

@MariusNi MariusNi commented Jun 4, 2024 •
edited
Loading

Description

Stabilizing audit and remediation for ASB v2, including fixes for:

  • AuditEnsureSyslogRotaterServiceIsEnabled
  • RemediateEnsureSyslogRotaterServiceIsEnabled
  • RemediateEnsurePacketRedirectSendingIsDisabled

Plus:

  • Adding unit-test coverage for a corner case of replacing escape sequences from strings and files, when the backslash character is alone at the end of the file or string.
  • Updating documentation to bring it up to date with the code.

Checklist

  • I have read the contribution guidelines.
  • I added unit-tests to validate my changes. All unit tests are passing.
  • I have merged the latest main branch prior to this PR submission.
  • I submitted this PR against the main branch.

@MariusNi MariusNi requested a review from a team as a code owner June 4, 2024 16:19
@MariusNi MariusNi changed the title TBD Continuing stabilization for ABS v2 audit and remediation Jun 4, 2024
@MariusNi MariusNi changed the title Continuing stabilization for ABS v2 audit and remediation Continuing stabilization for ASB v2 audit and remediation Jun 4, 2024
@MariusNi MariusNi merged commit 5205237 into main Jun 4, 2024
64 checks passed
@MariusNi MariusNi deleted the MariusNi/OsConfig_ASB_Jun03_2024 branch June 4, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertschaedler3 robertschaedler3 robertschaedler3 approved these changes

@simonjaeger simonjaeger simonjaeger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MariusNi @simonjaeger @robertschaedler3