Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated upload/download artifact to v4 - Changed test reporting action #701

Merged
merged 42 commits into from
Jun 7, 2024
Merged

Updated upload/download artifact to v4 - Changed test reporting action #701

merged 42 commits into from
Jun 7, 2024

Conversation

AhmedBM
Copy link
Contributor

@AhmedBM AhmedBM commented May 28, 2024 •
edited
Loading

Description

  • Fixed log artifact naming to prevent clobbering logs for separate policy packages
  • Upgraded upload/download artifacts to v4 to remove nodejs 16 warnings. As a result, had to change dorny-test-reporter as it did not support GitHub v4 artifacts.
  • Added EnricoMi/publish-unit-test-result-action for test reporting

Checklist

  • I have read the contribution guidelines.
  • All unit tests are passing.
  • I have merged the latest main branch prior to this PR submission.
  • I submitted this PR against the main branch.

@AhmedBM AhmedBM requested a review from a team as a code owner May 28, 2024 18:49
MariusNi
MariusNi previously approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@MariusNi MariusNi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@MariusNi MariusNi dismissed their stale review May 29, 2024 22:42

revoking review

MariusNi
MariusNi previously approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@MariusNi MariusNi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@github-actions GitHub Actions
Copy link

github-actions bot commented May 30, 2024 •
edited
Loading

Test Results

 44 files   44 suites   34m 42s ⏱️
  4 tests   4 ✅  0 💤 0 ❌
176 runs  154 ✅ 22 💤 0 ❌

Results for commit 5b32cc4.

♻️ This comment has been updated with latest results.

@AhmedBM AhmedBM changed the title Fixed logs artifact to be unique to prevent clobbering across different policy packages Updated upload/download artifact to v4 - Changed test reporting action May 30, 2024
MariusNi and others added 12 commits May 30, 2024 15:59
@MariusNi
Merge branch 'main' of https://github.com/Azure/azure-osconfig into a…
c91216a 
…hbenmes/fix_clobbered_artifacts_logs
@MariusNi
Merge branch 'ahbenmes/fix_clobbered_artifacts_logs' of https://githu…
421ec24 
…b.com/Azure/azure-osconfig into ahbenmes/fix_clobbered_artifacts_logs
@MariusNi
Merge branch 'main' of https://github.com/Azure/azure-osconfig into a…
5f6918e 
…hbenmes/fix_clobbered_artifacts_logs
@MariusNi
Merge branch 'main' of https://github.com/Azure/azure-osconfig into a…
18912aa 
…hbenmes/fix_clobbered_artifacts_logs
@AhmedBM
fixed permissions on report
1655f94
@AhmedBM
updated build-infra image
bb86304
@AhmedBM
Changed test report permissions
3adb27a
@AhmedBM
fixed test report
b84c7de
@AhmedBM
fixed report
332003b
@MariusNi
Merge branch 'main' of https://github.com/Azure/azure-osconfig into a…
337f901 
…hbenmes/fix_clobbered_artifacts_logs
@AhmedBM
Added chmod for logs
e5c454a
@AhmedBM
chmod changes
1b0cd43
@MariusNi MariusNi dismissed their stale review June 6, 2024 15:37

revoking review

MariusNi
MariusNi previously approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@MariusNi MariusNi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

AhmedBM and others added 18 commits June 6, 2024 16:17
@AhmedBM
chmod instead of chown
3de2ece
@MariusNi
Merge branch 'ahbenmes/fix_clobbered_artifacts_logs' of https://githu…
a467736 
…b.com/Azure/azure-osconfig into ahbenmes/fix_clobbered_artifacts_logs
@MariusNi
Test run with /var/log/ log files access restriction temporarily removed
237fccc
@MariusNi
One more try
8e57527
@MariusNi
Work in progress
f1e7f5f
@MariusNi
Work in progress
b988975
@MariusNi
Work in progress
e0d3fc3
@MariusNi
Work in progress
47c09ee
@MariusNi
Work in progress
e3ffb1f
@MariusNi
Work in progress
b8bc786
@MariusNi
Work in progress
b065b68
@MariusNi
Work in progress
6b69369
@MariusNi
Merge branch 'main' of https://github.com/Azure/azure-osconfig into a…
65fbf3d 
…hbenmes/fix_clobbered_artifacts_logs
@MariusNi
Merge branch 'main' of https://github.com/Azure/azure-osconfig into a…
724fa3a 
…hbenmes/fix_clobbered_artifacts_logs
@MariusNi
Work in progress
09a9d77
@MariusNi
Merge branch 'main' of https://github.com/Azure/azure-osconfig into a…
5c58ddf 
…hbenmes/fix_clobbered_artifacts_logs
@MariusNi
Work in progress
1421143
@MariusNi
Restoring temporary changes
8261b58
@MariusNi MariusNi dismissed their stale review June 7, 2024 16:39

revoking review

MariusNi
MariusNi previously approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@MariusNi MariusNi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@MariusNi MariusNi dismissed their stale review June 7, 2024 16:39

revoking review

MariusNi
MariusNi approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@MariusNi MariusNi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@MariusNi MariusNi merged commit 6cb9614 into main Jun 7, 2024
108 checks passed
@MariusNi MariusNi deleted the ahbenmes/fix_clobbered_artifacts_logs branch June 7, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MariusNi MariusNi MariusNi approved these changes

@robertschaedler3 robertschaedler3 robertschaedler3 approved these changes

@simonjaeger simonjaeger simonjaeger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AhmedBM @simonjaeger @robertschaedler3 @MariusNi