split out mount/OVF logic into get_environment #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As mount/OVF logic should be separate from get_username(), split it out into a new function get_environment().
jeremycline
approved these changes
May 22, 2024
jeremycline
reviewed
May 29, 2024
As mount_parse_ovf_env is a helper for media module, it makes sense to move the function to libazureinit/media. To use inspect_err function, stable since 1.76, specify the minimum Rust version of libazureinit to 1.76.0.
dongsupark
force-pushed
the
decouple-mount-username
branch
from
ec1a8f6 to
a5319ef
Compare
dongsupark
added a commit
to dongsupark/azure-init
that referenced
this pull request
Jun 26, 2024
Replace inspect_err with map_err, to lower the minimum Rust version from 1.76, which is apparently not wide-spread enough in other development environments. See also Azure#84 (review).
dongsupark
added a commit
to dongsupark/azure-init
that referenced
this pull request
Jun 26, 2024
Replace inspect_err with map_err, to remove requirement of the minimum Rust version from 1.76, which is apparently not wide-spread enough in other development environments. See also Azure#84 (review).
Closed
dongsupark
added a commit
that referenced
this pull request
Jun 26, 2024
Replace `inspect_err` with `map_err`, to remove requirement of the minimum Rust version from 1.76, which is apparently not wide-spread enough in other development environments. See also #84 (review).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mount/OVF logic should be separate from
get_username(), split it out into a new functionget_environment().Fixes #81