-
Notifications
You must be signed in to change notification settings - Fork 13
Allow for Enabling/Disabling KVP using Config #179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ec4cd50
to
bc07e75
Compare
cjp256
reviewed
Mar 18, 2025
cjp256
reviewed
Mar 18, 2025
cjp256
reviewed
Mar 18, 2025
cjp256
reviewed
Mar 18, 2025
bc07e75
to
91ec0e4
Compare
anhvoms
approved these changes
Mar 19, 2025
dongsupark
approved these changes
Mar 20, 2025
Co-authored-by: Dongsu Park <[email protected]>
cjp256
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the ability to enable or disable KVP logging through the
telemetry.kvp_diagnostics
field in the configuration.Changes
setup_layers
function now checksconfig.telemetry.kvp_diagnostics
before initializingemit_kvp_layer
.kvp_diagnostics = false
,emit_kvp_layer
is set toNone
, ensuring no logs are written to the EmitKVPStruct.config
isNone
, the default behavior (true
) is maintained.kvp.rs
to validate that no data is written when KVP is disabled.Key Point: Config Tracing & KVP Behavior
setup_layers
is called once withNone
, meaning the config values will still be written to KVP. Ifkvp_diagnostics = false
, KVP logging will stop after the second call tosetup_layers
, since the new subscriber overrides the previous one.Dependency on
probertson-cache-vm-id-logging-new
This PR is based on
probertson-cache-vm-id-logging-new
, as that branch introduces passingConfig
intosetup_layers
, which is required for this logic.Next Steps
probertson-cache-vm-id-logging-new
first.Resolves #152.