Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node22 behind hidden key #7932

Closed
wants to merge 1 commit into from
+32 −1
Closed

node22 behind hidden key #7932

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions server/src/stacks/2020-10-01/stacks/web-app-stacks/Node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@ import { WebAppStack } from '../../models/WebAppStackModel';
import { getDateString } from '../date-utilities';

const getNodeStack: (useIsoDateFormat: boolean) => WebAppStack = (useIsoDateFormat: boolean) => {
const node22EOL = getDateString(new Date('2026/04/30'), useIsoDateFormat);
const node20EOL = getDateString(new Date('2026/04/30'), useIsoDateFormat);
const node18EOL = getDateString(new Date('2025/04/30'), useIsoDateFormat);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these needed and correct? Asking as the PR title only states that you are adding node22 behind hidekey

const node16EOL = getDateString(new Date('2023/09/11'), useIsoDateFormat);
const node14EOL = getDateString(new Date('2023/04/30'), useIsoDateFormat);
const node12EOL = getDateString(new Date('2022/04/01'), useIsoDateFormat);
Expand Down Expand Up @@ -41,6 +44,34 @@ const getNodeStack: (useIsoDateFormat: boolean) => WebAppStack = (useIsoDateForm
},
],
},
{
displayText: 'Node 22',
value: '22',
minorVersions: [
{
displayText: 'Node 22 LTS',
value: '22-lts',
stackSettings: {
linuxRuntimeSettings: {
runtimeVersion: 'NODE|22-lts',
remoteDebuggingSupported: false,
isHidden: true,
appInsightsSettings: {
isSupported: true,
isDefaultOff: false,
},
gitHubActionSettings: {
isSupported: true,
supportedVersion: '22.x',
},
supportedFeatures: {
disableSsh: true,
},
},
},
},
],
},
{
displayText: 'Node 20',
value: '20',
Expand Down
2 changes: 1 addition & 1 deletion server/src/tests/Stacks/2020-10-01/web-app/validations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ function validateNodeStack(nodeStack) {
expect(nodeStack.displayText).to.equal('Node');
expect(nodeStack.value).to.equal('node');
expect(nodeStack.preferredOs).to.equal('linux');
expect(nodeStack.majorVersions.length).to.equal(12);
expect(nodeStack.majorVersions.length).to.equal(13);
expect(nodeStack).to.deep.equal(hardCodedNodeStack);
}

Expand Down
Loading