[DC][Sidecars] When using private registry with no credentials, treat…

… it as public (#7884) Co-authored-by: Yoona Oh <[email protected]>
Azure · Oct 28, 2024 · 23ef040 · 23ef040
1 parent 4bc53fb
commit 23ef040
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 5 deletions.
diff --git a/client-react/src/pages/app/deployment-center/container/DeploymentCenterContainerSettings.tsx b/client-react/src/pages/app/deployment-center/container/DeploymentCenterContainerSettings.tsx
@@ -72,7 +72,7 @@ const DeploymentCenterContainerSettings: React.FC<DeploymentCenterFieldProps<Dep
   useEffect(() => {
     let isSubscribed = true;
 
-    portalContext?.getBooleanFlight(ExperimentationConstants.FlightVariable.enableSidecarMigration).then(hasFlightEnabled => {
+    portalContext?.getBooleanFlight(ExperimentationConstants.FlightVariable.showDCReactView).then(hasFlightEnabled => {
       if (isSubscribed) {
         setEnableSidecarMigration(hasFlightEnabled);
       }

diff --git a/client-react/src/pages/app/deployment-center/utility/DeploymentCenterUtility.tsx b/client-react/src/pages/app/deployment-center/utility/DeploymentCenterUtility.tsx
@@ -733,10 +733,17 @@ export const getAuthSettings = (values: DeploymentCenterContainerFormData) => {
       passwordSecret = '';
     }
   } else if (values.registrySource === ContainerRegistrySources.privateRegistry) {
-    authType = SiteContainerAuthType.UserCredentials;
-    userManagedIdentityClientId = '';
-    userName = values.privateRegistryUsername;
-    passwordSecret = values.privateRegistryPassword;
+    if (values.privateRegistryUsername && values.privateRegistryPassword) {
+      authType = SiteContainerAuthType.UserCredentials;
+      userManagedIdentityClientId = '';
+      userName = values.privateRegistryUsername;
+      passwordSecret = values.privateRegistryPassword;
+    } else {
+      authType = SiteContainerAuthType.Anonymous;
+      userManagedIdentityClientId = '';
+      userName = '';
+      passwordSecret = '';
+    }
   }
 
   return {