Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Unsafe Tyehandling issue #1165

Merged
merged 4 commits into from
Feb 5, 2025
Merged

fix Unsafe Tyehandling issue #1165

merged 4 commits into from
Feb 5, 2025

Conversation

MaddyDev
Copy link
Contributor

Fix the type safe handling security issue created:
image

@MaddyDev MaddyDev changed the title fix #pragma warning CA2327 fix Unsafe Tyehandling issue Jan 28, 2025
@MaddyDev
Copy link
Contributor Author

MaddyDev commented Feb 4, 2025 •
edited
Loading

I ran the codeql locally and did not see any issues prop up, we're good here. And for anyone looking to run codeql locally: CodeQL - Overview

@MaddyDev MaddyDev merged commit 6697e7b into main Feb 5, 2025
2 checks passed
@MaddyDev MaddyDev deleted the maddy/fixTypeSafeIssue branch February 5, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VasuBhog VasuBhog VasuBhog approved these changes

@Charles-Gagnon Charles-Gagnon Charles-Gagnon approved these changes

@chlafreniere chlafreniere chlafreniere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MaddyDev @VasuBhog @Charles-Gagnon @chlafreniere