Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Azure.Identity dependency to 1.11.0 #2795

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

davidmrdavid
Copy link
Contributor

As in title, to address CVE: GHSA-wvxc-855f-jvrv

@davidmrdavid davidmrdavid requested review from cgillum and jviau and removed request for cgillum and jviau April 17, 2024 03:16
@davidmrdavid
Copy link
Contributor Author

If it looks good and CI is green, please just squash-and-merge

@@ -75,7 +75,7 @@
<DocumentationFile>$(AssemblyName).xml</DocumentationFile>
</PropertyGroup>
<ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.0'">
<PackageReference Include="Azure.Identity" Version="1.10.2" />
<PackageReference Include="Azure.Identity" Version="1.11.0" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update the 1.10.2 version further down as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we do, thanks for catching that: 2bbf50c

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth refactoring the csproj at some point to have these dependencies in a shared ItemGroup

@davidmrdavid davidmrdavid merged commit 9a5ce36 into dev Apr 17, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants