Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch deserialization bug in 2.13.1 #2745

Merged
merged 8 commits into from
Mar 13, 2024
Merged

Patch deserialization bug in 2.13.1 #2745

merged 8 commits into from
Mar 13, 2024

Conversation

davidmrdavid
Copy link
Contributor

@davidmrdavid davidmrdavid commented Feb 16, 2024 •
edited
Loading

As in title. Also adds de-/serialization tests in the smoke tests thanks to @bachuv

cgillum
cgillum approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@cgillum cgillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming we've done the manual validation of the fix and things are working as expected, LGTM.

@davidmrdavid davidmrdavid reopened this Mar 13, 2024
@bachuv bachuv changed the title [WIP] patch deserialization bug in 2.13.1 Patch deserialization bug in 2.13.1 Mar 13, 2024
@bachuv bachuv marked this pull request as ready for review March 13, 2024 20:51
davidmrdavid
davidmrdavid commented Mar 13, 2024
View reviewed changes
Copy link
Contributor Author

@davidmrdavid davidmrdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well. Just left a tiny nitpick for the JS case

test/SmokeTests/OOProcSmokeTests/durableJS/DurableFunctionsOrchestratorJS/index.js Outdated Show resolved Hide resolved
@bachuv bachuv merged commit 254b262 into dev Mar 13, 2024
20 checks passed
@bachuv bachuv deleted the dajusto/deserialization-patch branch March 13, 2024 23:20
@bachuv bachuv mentioned this pull request Mar 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bachuv bachuv bachuv left review comments

@cgillum cgillum cgillum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidmrdavid @cgillum @bachuv