Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CreateCheckStatusResponseAsync APIs #2722

Merged
merged 4 commits into from
Jan 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions release_notes.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

### New Features

- Add `CreateCheckStatusResponseAsync` APIs. (https://github.com/Azure/azure-functions-durable-extension/pull/2722)

### Bug Fixes

- Fix issue with isolated entities: custom deserialization was not working because IServices was not passed along (https://github.com/Azure/azure-functions-durable-extension/pull/2686)
Expand Down
66 changes: 59 additions & 7 deletions src/Worker.Extensions.DurableTask/DurableTaskClientExtensions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
using System;
using System.Net;
using System.Threading;
using System.Threading.Tasks;
using Azure.Core.Serialization;
using Microsoft.Azure.Functions.Worker.Http;
using Microsoft.DurableTask.Client;
Expand All @@ -17,6 +18,52 @@ namespace Microsoft.Azure.Functions.Worker;
/// </summary>
public static class DurableTaskClientExtensions
{
/// <summary>
/// Creates an HTTP response that is useful for checking the status of the specified instance.
/// </summary>
/// <param name="client">The <see cref="DurableTaskClient"/>.</param>
/// <param name="request">The HTTP request that this response is for.</param>
/// <param name="instanceId">The ID of the orchestration instance to check.</param>
/// <param name="cancellation">The cancellation token.</param>
/// <returns>An HTTP 202 response with a Location header and a payload containing instance control URLs.</returns>
public static Task<HttpResponseData> CreateCheckStatusResponseAsync(
this DurableTaskClient client,
HttpRequestData request,
string instanceId,
CancellationToken cancellation = default)
{
return client.CreateCheckStatusResponseAsync(request, instanceId, HttpStatusCode.Accepted, cancellation);
}

/// <summary>
/// Creates an HTTP response that is useful for checking the status of the specified instance.
/// </summary>
/// <param name="client">The <see cref="DurableTaskClient"/>.</param>
/// <param name="request">The HTTP request that this response is for.</param>
/// <param name="instanceId">The ID of the orchestration instance to check.</param>
/// <param name="statusCode">The status code.</param>
/// <param name="cancellation">The cancellation token.</param>
/// <returns>An HTTP response with a Location header and a payload containing instance control URLs.</returns>
public static async Task<HttpResponseData> CreateCheckStatusResponseAsync(
this DurableTaskClient client,
HttpRequestData request,
string instanceId,
HttpStatusCode statusCode,
CancellationToken cancellation = default)
{
if (client is null)
{
throw new ArgumentNullException(nameof(client));
}

HttpResponseData response = request.CreateResponse(statusCode);
object payload = SetHeadersAndGetPayload(client, request, response, instanceId);

ObjectSerializer serializer = GetObjectSerializer(response);
await serializer.SerializeAsync(response.Body, payload, payload.GetType(), cancellation);
jviau marked this conversation as resolved.
Show resolved Hide resolved
return response;
}

/// <summary>
/// Creates an HTTP response that is useful for checking the status of the specified instance.
/// </summary>
Expand Down Expand Up @@ -55,6 +102,17 @@ public static HttpResponseData CreateCheckStatusResponse(
throw new ArgumentNullException(nameof(client));
}

HttpResponseData response = request.CreateResponse(statusCode);
object payload = SetHeadersAndGetPayload(client, request, response, instanceId);

ObjectSerializer serializer = GetObjectSerializer(response);
serializer.Serialize(response.Body, payload, payload.GetType(), cancellation);
return response;
}

private static object SetHeadersAndGetPayload(
DurableTaskClient client, HttpRequestData request, HttpResponseData response, string instanceId)
{
static string BuildUrl(string url, params string?[] queryValues)
{
bool appended = false;
Expand All @@ -79,23 +137,17 @@ static string BuildUrl(string url, params string?[] queryValues)
string formattedInstanceId = Uri.EscapeDataString(instanceId);
string instanceUrl = $"{baseUrl}/runtime/webhooks/durabletask/instances/{formattedInstanceId}";
string? commonQueryParameters = GetQueryParams(client);

HttpResponseData response = request.CreateResponse(statusCode);
response.Headers.Add("Location", BuildUrl(instanceUrl, commonQueryParameters));
response.Headers.Add("Content-Type", "application/json");

ObjectSerializer serializer = GetObjectSerializer(response);
var payload = new
return new
{
id = instanceId,
purgeHistoryDeleteUri = BuildUrl(instanceUrl, commonQueryParameters),
sendEventPostUri = BuildUrl($"{instanceUrl}/raiseEvent/{{eventName}}", commonQueryParameters),
statusQueryGetUri = BuildUrl(instanceUrl, commonQueryParameters),
terminatePostUri = BuildUrl($"{instanceUrl}/terminate", "reason={{text}}}", commonQueryParameters),
};

serializer.Serialize(response.Body, payload, payload.GetType(), cancellation);
return response;
}

private static ObjectSerializer GetObjectSerializer(HttpResponseData response)
Expand Down
Loading