Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge feature/core-entities to dev #2574

Merged
merged 31 commits into from
Oct 19, 2023
Merged

Conversation

sebastianburckhardt
Copy link
Collaborator

@sebastianburckhardt sebastianburckhardt commented Sep 7, 2023

This is the feature branch for the new support of entities in DT.Core and in Isolated.

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation PR is ready to merge and referenced in pending_docs.md
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)
  • My changes do not require any extra work to be leveraged by OutOfProc SDKs
    • Otherwise: That work is being tracked here: #issue_or_pr_in_each_sdk
  • My changes do not change the version of the WebJobs.Extensions.DurableTask package
    • Otherwise: major or minor version updates are reflected in /src/Worker.Extensions.DurableTask/AssemblyInfo.cs
  • My changes do not add EventIds to our EventSource logs
    • Otherwise: Ensure the EventIds are within the supported range in our existing Windows infrastructure. You may validate this with a deployed app's telemetry. You may also extend the range by completing a PR such as this one.

@sebastianburckhardt sebastianburckhardt added the core-entities required for entity support in isolated label Sep 7, 2023
@sebastianburckhardt sebastianburckhardt marked this pull request as draft September 7, 2023 17:48
@sebastianburckhardt sebastianburckhardt added the P1 Priority 1 label Sep 7, 2023
sebastianburckhardt and others added 24 commits September 11, 2023 16:17
* update durability provider class for new core-entities support.

* add configuration setting for max entity concurrency to DurableTaskOptions

* minor fixes.
* update DurableClient to take advantage of native entity queries if available

* fix minor errors.

* address PR feedback
* implement passthrough middleware for entities.

* propagate changes to protocol

* update/simplify protobuf format

* address PR feedback
* implement entity queries for grpc listener

* propagate changes to protocol

* update/simplify protobuf format
Merge dev to main for 2.11.2 release
Merge dev to main for 2.11.3 release
* durability provider must implement and pass-through IEntityOrchestrationService since it wraps the orchestration service

* simple mistake

* fix misunderstanding of initializer syntax (produced null, not empty list)

* fix missing failure details

* fix missing compile-time switch for trigger value type

* fix missing optional arguments

* fix  missing override
* add an entity example to the DotNetIsolated smoke test project.

* remove superfluous argument.

* address PR feedback
* Add worker side entity trigger and logic

* update comments

* Address PR comments
* assign the necessary AzureStorageOrchestrationServiceSettings

* propagate changes to query name and metadata parameters

* add missing override for TaskOrchestrationEntityFeature
* add configuration for EnableEntitySupport

* rename includeStateless to includeTransient
…ions are called on a backend that does not support entities (#2630)
jviau added 2 commits October 18, 2023 13:59
# Conflicts:
#	release_notes.md
#	src/WebJobs.Extensions.DurableTask/WebJobs.Extensions.DurableTask.csproj
#	src/Worker.Extensions.DurableTask/AssemblyInfo.cs
#	src/Worker.Extensions.DurableTask/Worker.Extensions.DurableTask.csproj
#	test/SmokeTests/OOProcSmokeTests/DotNetIsolated/DotNetIsolated.csproj
@jviau jviau changed the title [WIP] feature/core-entities Merge feature/core-entities to dev Oct 18, 2023
@jviau jviau marked this pull request as ready for review October 18, 2023 21:21
jviau and others added 2 commits October 18, 2023 15:22
* fix translation of legacy query to new entity query support

* comment out CleanEntityStorage_Many

* try to enable CI on feature branch

* Revert "comment out CleanEntityStorage_Many"

This reverts commit aeaa4b8.

* update to preview.2 packages
@sebastianburckhardt sebastianburckhardt merged commit bbd7ad6 into dev Oct 19, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-entities required for entity support in isolated P1 Priority 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants