Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gRPC implementation used by out-of-proc v2 SDKs #2312

Merged
merged 2 commits into from
Nov 15, 2022
Merged

Update gRPC implementation used by out-of-proc v2 SDKs #2312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2118395
Update protobuf reference
cgillum Nov 15, 2022
e30bb90
Update release notes
cgillum Nov 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion release_notes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
## Updates

* Added V2 middleware support for custom handlers
* Added V2 middleware support for custom handlers
* Added suspend, resume, and rewind operation handling for V2 out-of-proc
* Updated Microsoft.DurableTask.Sidecar.Protobuf dependency to v1.0.0
18 changes: 18 additions & 0 deletions src/WebJobs.Extensions.DurableTask/LocalGrpcListener.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,24 @@ await this.durabilityProvider.ForceTerminateTaskOrchestrationAsync(
return new P.TerminateResponse();
}

public override async Task<P.SuspendResponse> SuspendInstance(P.SuspendRequest request, ServerCallContext context)
{
await this.durabilityProvider.SuspendTaskOrchestrationAsync(request.InstanceId, request.Reason);
return new P.SuspendResponse();
}

public override async Task<P.ResumeResponse> ResumeInstance(P.ResumeRequest request, ServerCallContext context)
{
await this.durabilityProvider.ResumeTaskOrchestrationAsync(request.InstanceId, request.Reason);
return new P.ResumeResponse();
}

public override async Task<P.RewindInstanceResponse> RewindInstance(P.RewindInstanceRequest request, ServerCallContext context)
{
await this.durabilityProvider.RewindAsync(request.InstanceId, request.Reason);
return new P.RewindInstanceResponse();
}

public override async Task<P.GetInstanceResponse> GetInstance(P.GetInstanceRequest request, ServerCallContext context)
{
OrchestrationState state = await this.durabilityProvider.GetOrchestrationStateAsync(request.InstanceId, executionId: null);
Expand Down
5 changes: 2 additions & 3 deletions src/WebJobs.Extensions.DurableTask/WebJobs.Extensions.DurableTask.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,9 +101,8 @@
<PackageReference Include="Microsoft.ApplicationInsights" Version="2.12.2" />
<!-- Explicitly pinned transitive dependencies with CVE vulnerabilities.-->
<PackageReference Include="Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets" Version="2.2.1" />
<!-- The gRPC dependencies are not compatible with .NET Standard 2.0 and will fail at runtime -->
<PackageReference Include="Grpc" Version="2.38.0" />
<PackageReference Include="Microsoft.DurableTask.Sidecar.Protobuf" Version="0.3.1" />
<!-- The gRPC dependencies in this package are not compatible with older frameworks, like .NET Core 2.x -->
<PackageReference Include="Microsoft.DurableTask.Sidecar.Protobuf" Version="1.0.0" />
</ItemGroup>


Expand Down