apply feedback

Azure · Apr 5, 2024 · eb85ff2 · eb85ff2
1 parent 1dc5dae
commit eb85ff2
Showing 1 changed file with 11 additions and 4 deletions.
diff --git a/src/WebJobs.Extensions.DurableTask/LocalGrpcListener.cs b/src/WebJobs.Extensions.DurableTask/LocalGrpcListener.cs
@@ -155,11 +155,18 @@ public override Task<Empty> Hello(Empty request, ServerCallContext context)
                         InstanceId = instanceId,
                     };
                 }
-                catch (InvalidOperationException ex)
+                catch (OrchestrationAlreadyExistsException ex)
                 {
-                    string errorMessage = $"Failed to start instance with ID {request.InstanceId}. Does this instance ID already exist?.\n" +
-                        $"Inner exception: {ex}";
-                    throw new RpcException(new Status(StatusCode.AlreadyExists, errorMessage));
+                    throw new RpcException(new Status(StatusCode.AlreadyExists, $"An Orchestration instance with the ID {request.InstanceId} already exists."));
+                }
+                catch (Exception ex)
+                {
+                    this.extension.TraceHelper.ExtensionWarningEvent(
+                        this.extension.Options.HubName,
+                        functionName: request.Name,
+                        instanceId: request.InstanceId,
+                        message: $"Failed to start instanceId {request.InstanceId} due to internal exception.\n Exception trace: {ex}.");
+                    throw new RpcException(new Status(StatusCode.Internal, $"Failed to start instance with ID {request.InstanceId}. Does this instance ID already exist?.\n"));
                 }
             }