Skip to content

Commit

Permalink
stabilize tests
Browse files Browse the repository at this point in the history
  • Loading branch information
davidmrdavid committed Jun 19, 2024
1 parent 6432f5d commit 585e4a6
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
6 changes: 4 additions & 2 deletions .github/workflows/validate-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,13 +44,15 @@ jobs:
- name: Build
run: dotnet build $solution #--configuration $config #--no-restore -p:FileVersionRevision=$GITHUB_RUN_NUMBER -p:ContinuousIntegrationBuild=true

- name: Set up Node.js
# Install Azurite
- name: Set up Node.js (needed for Azurite)
uses: actions/setup-node@v3
with:
node-version: '18.x' # Azurite requires at least Node 18

- name: Install Azurite
run: npm install -g azurite

- name: Test DTx.Core
# Run tests
- name: Test FunctionsV2 tests
run: azurite --silent --blobPort 10000 --queuePort 10001 --tablePort 10002 & dotnet test ./test/FunctionsV2/WebJobs.Extensions.DurableTask.Tests.V2.csproj --filter "FullyQualifiedName~DurableTaskEndToEndTests.OutputsValidJSONLogs" #--configuration $config --no-build --verbosity normal
3 changes: 3 additions & 0 deletions test/Common/DurableTaskEndToEndTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -746,6 +746,9 @@ await TestHelpers.WaitUntilTrue(
conditionDescription: "Log file exists",
timeout: TimeSpan.FromSeconds(30));

// add a minute wait to ensure logs are fully written
await Task.Delay(TimeSpan.FromMinutes(1));

await TestHelpers.WaitUntilTrue(
predicate: () =>
{
Expand Down

0 comments on commit 585e4a6

Please sign in to comment.