Skip to content

Commit

Permalink
Update MSSQL smoke test (#2792)
Browse files Browse the repository at this point in the history
This PR removes the SA_PASSWORD hard coded environment variable from the MSSQL smoke test. Instead, a password for the SQL server is set as a repository secret.
  • Loading branch information
bachuv authored Apr 18, 2024
1 parent 9a5ce36 commit 182013e
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion .github/workflows/smoketest-mssql-inproc-v4.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,20 @@ on:
paths:
- 'src/**'
- 'test/SmokeTests/BackendSmokeTests/MSSQL/**'
- '.github/workflows/smoketest-mssql-inproc-v4.yml'
pull_request:
branches: [ main, dev ]
paths:
- 'src/**'
- 'test/SmokeTests/BackendSmokeTests/MSSQL/**'
- '.github/workflows/smoketest-mssql-inproc-v4.yml'

jobs:
build:

runs-on: ubuntu-latest
env:
SA_PASSWORD: NotASecret!12
SA_PASSWORD: ${{ secrets.SA_PASSWORD }}

steps:
- uses: actions/checkout@v4
Expand Down

0 comments on commit 182013e

Please sign in to comment.