Refactor CosmosDBConverter to remove use reflection #1924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fabiocav let me know if this is vastly different to what you had in mind - happy to make adjustments for improvement but figured it would be nice to get this out before I release cosmos 4.5.0 |
kshyju
reviewed
Sep 26, 2023
jviau
reviewed
Sep 27, 2023
jviau
reviewed
Sep 29, 2023
jviau
requested changes
Oct 17, 2023
extensions/Worker.Extensions.Shared/Extensions/TypeExtensions.cs
Outdated
Show resolved
Hide resolved
microsoft-github-policy-service
bot
added
Needs: Author Feedback
and removed
Needs: Author Feedback
labels
liliankasem
force-pushed
the
liliankasem/refactor/cosmos-converter
branch
from
be81448 to
9972c85
Compare
jviau
previously requested changes
Oct 23, 2023
extensions/Worker.Extensions.Shared/Extensions/TypeExtensions.cs
Outdated
Show resolved
Hide resolved
extensions/Worker.Extensions.Shared/Extensions/TypeExtensions.cs
Outdated
Show resolved
Hide resolved
microsoft-github-policy-service
bot
added
Needs: Author Feedback
and removed
Needs: Author Feedback
labels
jviau
reviewed
Oct 24, 2023
Co-authored-by: Jacob Viau <[email protected]>
liliankasem
force-pushed
the
liliankasem/refactor/cosmos-converter
branch
from
c73ea0e to
e69dc8f
Compare
|
@fabiocav this is ready for review now. I started the work of extracting common collection binding helpers that we can hopefully apply to other extensions in time. |
jviau
force-pushed
the
liliankasem/refactor/cosmos-converter
branch
from
5840fa0 to
f6f2c47
Compare
liliankasem
commented
Nov 28, 2023
jviau
approved these changes
Dec 5, 2023
test/Worker.Extensions.Shared.Tests/Reflection/ParameterBinderTests.cs
Outdated
Show resolved
Hide resolved
This was referenced Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #1613
Pull request checklist
release_notes.mdAdditional information
This is the approach I could think of but if there is a better way I'm all for it!